diff options
author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-30 21:28:16 +0000 |
---|---|---|
committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-30 21:28:16 +0000 |
commit | 72fda76dd8db93d169de80a7a4a47a4f1bec64e8 (patch) | |
tree | d6d96ab2bccefe6d20e82a0d778308a8688cca84 /tools | |
parent | 4d34b576b9ce89b61fb7b0d98217f9faaa6c8d4d (diff) | |
download | chromium_src-72fda76dd8db93d169de80a7a4a47a4f1bec64e8.zip chromium_src-72fda76dd8db93d169de80a7a4a47a4f1bec64e8.tar.gz chromium_src-72fda76dd8db93d169de80a7a4a47a4f1bec64e8.tar.bz2 |
Fix missing line in suppression; move the suppression to the more appropriate place.
TBR=dank
Review URL: http://codereview.chromium.org/344040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 27 |
1 files changed, 14 insertions, 13 deletions
diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index 65740f4..d7c9027 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -75,6 +75,20 @@ fun:*browser_sync*BookmarkModelWorker* } +# The race happens during enumeration of ChromeThreads. +# For each ChromeThread we check whether its message_loop() +# equals MessageLoop::current(). +# The race can happen if one of the ChromeThreads is exiting. +# This is benign since current thread can't exit while we +# execute GetCurrentThreadIdentifier() and other message_loops +# won't match the current one anyway. +{ + Benign race under ChromeThread::GetCurrentThreadIdentifier + ThreadSanitizer:Race + fun:*base*Thread*message_loop* + fun:*ChromeThread*GetCurrentThreadIdentifier* +} + ############################ # Real races in third_party { @@ -112,19 +126,6 @@ fun:*talk_base*MessageQueue*Get* } -# The race happens during enumeration of ChromeThreads. -# For each ChromeThread we check whether its message_loop() -# equals MessageLoop::current(). -# The race can happen if one of the ChromeThreads is exiting. -# This is benign since current thread can't exit while we -# execute GetCurrentThreadIdentifier() and other message_loops -# won't match the current one anyway. -{ - Benign race under ChromeThread::GetCurrentThreadIdentifier - fun:*base*Thread*message_loop* - fun:*ChromeThread*GetCurrentThreadIdentifier* -} - ############################ # Data races in tests |