diff options
| author | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-06 00:43:00 +0000 |
|---|---|---|
| committer | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-06 00:43:00 +0000 |
| commit | 596fe0c18f6bdcbb8a89adbdd53940927dfccbc3 (patch) | |
| tree | e6ed6de2d16484bed2f29977edb631c41a422edc /tools | |
| parent | 71421c3fc725d9d55acba7a4233525f8b6e07350 (diff) | |
| download | chromium_src-596fe0c18f6bdcbb8a89adbdd53940927dfccbc3.zip chromium_src-596fe0c18f6bdcbb8a89adbdd53940927dfccbc3.tar.gz chromium_src-596fe0c18f6bdcbb8a89adbdd53940927dfccbc3.tar.bz2 | |
Re-Retry. This is the change from hell.
Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true.
---
I believe the code (with your width() * bbp fix) is correct.
The UMR errors occur when the source image contain alpha. I believe the issue
comes from webkit glue image decoder, and the reason this only started
triggering valgrind errors is that the old ones were masked by the change
detailed in bug 12640
Also adds valgrind suppression for the new code.
TBR=Nick
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/119271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17811 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/suppressions_mac.txt | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/tools/valgrind/suppressions_mac.txt b/tools/valgrind/suppressions_mac.txt index 1db729f..66bc8c2 100644 --- a/tools/valgrind/suppressions_mac.txt +++ b/tools/valgrind/suppressions_mac.txt @@ -220,3 +220,13 @@ fun:write$UNIX2003 fun:_ZN24ExtensionsServiceBackend19OnExtensionUnpackedERK8FilePathS2_SsbRK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmapS0_ESaIS9_EE } +{ + bug_12640d + Memcheck:Cond + fun:_ZN10PNGEncoder18EncodeBGRASkBitmapERK8SkBitmapbPSt6vectorIhSaIhEE + fun:_ZN24ExtensionsServiceBackend19OnExtensionUnpackedERK8FilePathS2_SsbRK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmapS0_ESaIS9_EE + fun:_ZN24ExtensionsServiceBackend14UnpackerClient26OnUnpackExtensionSucceededERK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmap8FilePathESaIS8_EE + ... + fun:_ZN11MessageLoop13RunAllPendingEv +} + |