diff options
| author | danhn@chromium.org <danhn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 20:10:23 +0000 |
|---|---|---|
| committer | danhn@chromium.org <danhn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 20:10:23 +0000 |
| commit | 8c096e0a8e97626690858e375305b642d9e332e0 (patch) | |
| tree | 61b074dc156a0bb8078cc7ecb8994b8b0baa228a /tools | |
| parent | 47add235920532afd026c068426701a27eb1154b (diff) | |
| download | chromium_src-8c096e0a8e97626690858e375305b642d9e332e0.zip chromium_src-8c096e0a8e97626690858e375305b642d9e332e0.tar.gz chromium_src-8c096e0a8e97626690858e375305b642d9e332e0.tar.bz2 | |
Skips testActivateTab on old browsers which don't support tab control.
BUG=168984
Review URL: https://chromiumcodereview.appspot.com/11819045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176136 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/telemetry/telemetry/tab.py | 3 | ||||
| -rw-r--r-- | tools/telemetry/telemetry/tab_unittest.py | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/tools/telemetry/telemetry/tab.py b/tools/telemetry/telemetry/tab.py index 3fc0dac..4cd7dc7 100644 --- a/tools/telemetry/telemetry/tab.py +++ b/tools/telemetry/telemetry/tab.py @@ -72,6 +72,9 @@ class Tab(object): def Activate(self): """Brings this tab to the foreground asynchronously. + Not all browsers or browser versions support this method. + Be sure to check browser.supports_tab_control. + Please note: this is asynchronous. There is a delay between this call and the page's documentVisibilityState becoming 'visible', and yet more delay until the actual tab is visible to the user. None of these delays diff --git a/tools/telemetry/telemetry/tab_unittest.py b/tools/telemetry/telemetry/tab_unittest.py index 3727f02..f6906b2 100644 --- a/tools/telemetry/telemetry/tab_unittest.py +++ b/tools/telemetry/telemetry/tab_unittest.py @@ -30,6 +30,8 @@ class TabTest(tab_test_case.TabTestCase): timeout=5)) def testActivateTab(self): + if not self._browser.supports_tab_control: + return self.assertTrue(_IsDocumentVisible(self._tab)) new_tab = self._browser.tabs.New() util.WaitFor(lambda: _IsDocumentVisible(new_tab), timeout=5) |