diff options
| author | erg <erg@chromium.org> | 2014-10-15 17:56:34 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-16 00:56:55 +0000 |
| commit | a053ef69be56c9d073a8e383491e0f0854240250 (patch) | |
| tree | 1bcfd64657c9e26b280a652b4d39c43924cb757a /tools | |
| parent | 4b6b5ff0fe1f0bb9c06290462253704bd816aa5d (diff) | |
| download | chromium_src-a053ef69be56c9d073a8e383491e0f0854240250.zip chromium_src-a053ef69be56c9d073a8e383491e0f0854240250.tar.gz chromium_src-a053ef69be56c9d073a8e383491e0f0854240250.tar.bz2 | |
gn: Check GN_EDITOR before EDITOR in environment variables.
It's a convention in unix for programs to first search for a program
specific editor variable. For example, SVN_EDITOR or GIT_EDITOR. This
makes GN follow this same convention.
BUG=none
Review URL: https://codereview.chromium.org/654333002
Cr-Commit-Position: refs/heads/master@{#299798}
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/gn/command_args.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc index e2f4a9c..8098ea1 100644 --- a/tools/gn/command_args.cc +++ b/tools/gn/command_args.cc @@ -196,9 +196,10 @@ bool RunEditor(const base::FilePath& file_to_edit) { #else // POSIX bool RunEditor(const base::FilePath& file_to_edit) { - // Prefer $VISUAL, then $EDITOR, then vi. const char* editor_ptr = getenv("VISUAL"); if (!editor_ptr) + editor_ptr = getenv("GN_EDITOR"); + if (!editor_ptr) editor_ptr = getenv("EDITOR"); if (!editor_ptr) editor_ptr = "vi"; |