diff options
| author | vrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 00:12:38 +0000 |
|---|---|---|
| committer | vrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-26 00:12:38 +0000 |
| commit | 2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9 (patch) | |
| tree | d3223ba6aa7a9c6e75de2c2992ca0eb8c73f9f4c /tools | |
| parent | cb592c2a727cb7e9609a4b5dccf4e719ab120088 (diff) | |
| download | chromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.zip chromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.tar.gz chromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.tar.bz2 | |
Fixes ReadInternal() memory leak from BufferedDataSource tests
Makes Read() calls from the loader class automatically delete the given
ReadCallback by default, so as to prevent memory leaks when a test does
not explicitly delete the ReadCallback. Also deletes valgrind and heapcheck
suppressions associated with this fix.
BUG=60381
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/4116001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63817 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 10 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 22 |
2 files changed, 0 insertions, 32 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index d9d58f9..7e1ae4d 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1109,13 +1109,3 @@ fun:main fun:__libc_start_main } -{ - bug_60381 - Heapcheck:Leak - fun:Callback1::Type* NewCallback - fun:webkit_glue::BufferedDataSource::ReadInternal - fun:webkit_glue::BufferedDataSource::ReadTask - fun:void DispatchToMethod - fun:RunnableMethod::Run - fun:MessageLoop::RunTask -} diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 072525b..445de8c 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3032,28 +3032,6 @@ fun:_ZN3IPC11SyncChannel11SyncContext16DispatchMessagesEv } { - bug_60381a - Memcheck:Leak - fun:_Znw* - fun:_Z11NewCallbackIN11webkit_glue18BufferedDataSourceEiEPN9Callback1IT0_E4TypeEPT_MS7_FvS3_E - fun:_ZN11webkit_glue18BufferedDataSource12ReadInternalEv - fun:_ZN11webkit_glue18BufferedDataSource8ReadTaskExiPhP14CallbackRunnerI6Tuple1IjEE - fun:_Z16DispatchToMethodIN11webkit_glue18BufferedDataSourceEMS1_FvxiPhP14CallbackRunnerI6Tuple1IjEEExiS2_S7_EvPT_T0_RK6Tuple4IT1_T2_T3_T4_E - fun:_ZN14RunnableMethodIN11webkit_glue18BufferedDataSourceEMS1_FvxiPhP14CallbackRunnerI6Tuple1IjEEE6Tuple4IxiS2_S7_EE3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task -} -{ - bug_60381b - Memcheck:Leak - fun:_Znw* - fun:_Z11NewCallbackIN11webkit_glue18BufferedDataSourceEiEPN9Callback1IT0_E4TypeEPT_MS7_FvS3_E - fun:_ZN11webkit_glue18BufferedDataSource12ReadInternalEv - fun:_ZN11webkit_glue18BufferedDataSource8ReadTaskExiPhP14CallbackRunnerI6Tuple1ImEE - fun:_Z16DispatchToMethodIN11webkit_glue18BufferedDataSourceEMS1_FvxiPhP14CallbackRunnerI6Tuple1ImEEExiS2_S7_EvPT_T0_RK6Tuple4IT1_T2_T3_T4_E - fun:_ZN14RunnableMethodIN11webkit_glue18BufferedDataSourceEMS1_FvxiPhP14CallbackRunnerI6Tuple1ImEEE6Tuple4IxiS2_S7_EE3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task -} -{ bug_60612 Memcheck:Leak fun:_Znw* |