diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-07 18:35:15 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-07 18:35:15 +0000 |
| commit | 34dc5d9713620a3859d4b12cf400d0314d68a043 (patch) | |
| tree | 426a1336ef4b6db7f47c223ccc27eba830678ee3 /tools | |
| parent | 3fae54b2355ba858551f875245d135bf17f0d5c5 (diff) | |
| download | chromium_src-34dc5d9713620a3859d4b12cf400d0314d68a043.zip chromium_src-34dc5d9713620a3859d4b12cf400d0314d68a043.tar.gz chromium_src-34dc5d9713620a3859d4b12cf400d0314d68a043.tar.bz2 | |
This CL fixes issue 2780 - RTL: Omnibar - message "Press Tab to search Google" doesn't show correctly in a "New Tab" for RTL locales.
(http://crbug.com/2780)
The error happens in LocationBarView::TextDisplayWidth() which does not correctly calculate the location entry's text display width.
The fix itself contains comments so hope it is self-explained.
Test steps:
1. Start Chrome with a new user data directory (or clean up all browsing data) and make sure the UI language is Hebrew.
2 Type www.google.com in the omnibox and press Enter.
3 Close and re-open the browser.
4 Type character "h" in Ominibox
Without the fix, only "tab" button is showing as keyword hint.
With the fix, Hebrew translation of "press tab to search google" is displayed. Please be noted: you need to have enough space in omnibox in order for the whole keyword hint to be displayed, otherwise, only "tab" button will be displayed.
Review URL: http://codereview.chromium.org/100360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15562 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions