Fishing expedition in mac ui tests.

Adds suppressions for lots of bugs.  The only
problems left I know of result in valgrind internal
error messages.

Widen suppression for 16128 to match on Mac.
Remove suppression for 16210, which is a dup of 16128, and was out of date.

The reference builds don't have symbols on the mac,
so suppressions don't work. And they have old known
valgrind issues.  Disable
SunSpiderReferenceTest.Perf and
V8BenchmarkReferenceTest.Perf under valgrind until
those problems are addressed (and possibly longer --
reference builds tend to have old valgrind errors
since fixed and no longer of interest).

Also, disable DownloadTest.UnknownSize under valgrind,
it is known to send garbage.

None of these errors are showing up on the bots
for some reason; they only show up when you do
a local run of shard_all_tests.sh, which does one
test at a time instead of the normal batches of 30.
It seems valgrind on the mac isn't stable enough
to do large batches of ui tests in a single run.

BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540
TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings

Review URL: http://codereview.chromium.org/159770

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 118 insertions, 13 deletions

diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index f5f94a0..d0a199b 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -731,7 +731,7 @@
 {
    bug_16128
    Memcheck:Leak
-   fun:_Znwj
+   fun:_Znw*
    fun:_ZN3IPC11SyncChannelC1ERKSsNS_7Channel4ModeEPNS3_8ListenerEPNS_12ChannelProxy13MessageFilterEP11MessageLoopbPN4base13WaitableEventE
    fun:_ZN11ChildThread4InitEv
 }
@@ -892,6 +892,17 @@
    fun:_ZN7WebCore5Frame4initEv
 }
 {
+   bug_17113
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN18ResourceDispatcher12CreateBridgeERKSsRK4GURLS4_S4_S1_S1_S1_iiN12ResourceType4TypeEjii
+   fun:_ZN11webkit_glue20ResourceLoaderBridge6CreateERKSsRK4GURLS5_S5_S2_S2_S2_iiN12ResourceType4TypeEii
+   fun:_ZN11webkit_glue16WebURLLoaderImpl7Context5StartERKN6WebKit13WebURLRequestEPNS_20ResourceLoaderBridge16SyncLoadResponseE
+   fun:_ZN11webkit_glue16WebURLLoaderImpl18loadAsynchronouslyERKN6WebKit13WebURLRequestEPNS1_18WebURLLoaderClientE
+   fun:_ZN11webkit_glue15ResourceFetcher5StartEP8WebFrame
+   fun:_ZN11webkit_glue15ResourceFetcherC1ERK4GURLP8WebFrameP14CallbackRunnerI6Tuple2IRKN6WebKit14WebURLResponseERKSsEE
+}
+{
    bug_17185
    Memcheck:Leak
    fun:malloc
@@ -925,6 +936,18 @@
    fun:_ZN3IPC11SyncChannelC1ERKSsNS_7Channel4ModeEPNS3_8ListenerEPNS_12ChannelProxy13MessageFilterEP11MessageLoopbPN4base13WaitableEventE
 }
 {
+   bug_17451
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN11webkit_glue16WebURLLoaderImplC1Ev
+   fun:_ZN11webkit_glue16WebKitClientImpl15createURLLoaderEv
+   fun:_ZN11webkit_glue15ResourceFetcher5StartEP8WebFrame
+   fun:_ZN11webkit_glue15ResourceFetcherC1ERK4GURLP8WebFrameP14CallbackRunnerI6Tuple2IRKN6WebKit14WebURLResponseERKSsEE
+   fun:_ZN11webkit_glue20ImageResourceFetcherC1ERK4GURLP8WebFrameiiP14CallbackRunnerI6Tuple2IPS0_RK8SkBitmapEE
+   fun:_ZN11WebViewImpl13DownloadImageEiRK4GURLi
+   fun:_ZN10RenderView17OnDownloadFavIconEiRK4GURLi
+}
+{
    bug_17540
    Memcheck:Leak
    fun:_Znw*
@@ -954,3 +977,9 @@
    fun:_ZN7WebCore12AtomicStringC1EPKc
    fun:_ZN7WebCore8SVGNames4initEv
 }
+{
+   bug_18268
+   Memcheck:Cond
+   fun:_ZN20NavigationController22IsLikelyAutoNavigationEN4base9TimeTicksE
+   fun:_ZN20NavigationController28RendererDidNavigateToNewPageERK32ViewHostMsg_FrameNavigate_ParamsPb
+}
diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt
index 4c0046d..375a56ec 100644
--- a/tools/valgrind/memcheck/suppressions_mac.txt
+++ b/tools/valgrind/memcheck/suppressions_mac.txt
@@ -156,6 +156,24 @@
    fun:ActivateTSMDocument
 }
 {
+   bug_18540
+   Memcheck:Leak
+   fun:malloc_zone_malloc
+   fun:_CFRuntimeCreateInstance
+   fun:__CFArrayInit
+   fun:CFArrayCreate
+   fun:-[__NSPlaceholderArray initWithObjects:count:]
+   fun:-[NSArray initWithObjects:]
+   fun:-[RenderWidgetHostViewCocoa validAttributesForMarkedText]
+   fun:-[NSTSMInputContext initWithClient:]
+   fun:+[NSInputContext inputContextWithClient:]
+   fun:-[NSView inputContext]
+   fun:+[NSInputContext currentInputContext]
+   fun:+[NSInputContext updateInputContexts]
+   fun:-[NSApplication updateWindows]
+   fun:_handleWindowsNeedUpdateNote
+}
+{
    # Looks like an Apple bug; has no visual impact.
    unitialized_rect_allocated_on_stack_when_reparenting_window_content_views
    Memcheck:Cond
@@ -187,6 +205,12 @@
    fun:-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
    fun:-[NSApplication run]
 }
+{
+   bug_18223
+   Memcheck:Cond
+   fun:_ZNK8Security12UnixPlusPlus17StaticForkMonitorclEv
+   fun:_ZN12ocspdGlobals10serverPortEv
+}
 
 # 2. Intentional unit test errors, stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing.
@@ -323,18 +347,6 @@
    fun:_ZN3IPC11SyncChannel11SyncContext17OnMessageReceivedERKNS_7MessageE
 }
 {
-   bug_16210
-   Memcheck:Leak
-   fun:_Znwm
-   fun:_ZN3IPC11SyncChannelC1ERKSsNS_7Channel4ModeEPNS3_8ListenerEPNS_12ChannelProxy13MessageFilterEP11MessageLoopbPN4base13WaitableEventE
-   fun:_ZN11ChildThread4InitEv
-   fun:_ZN12RenderThread4InitEv
-   fun:_ZN4base6Thread10ThreadMainEv
-   fun:_ZL10ThreadFuncPv
-   fun:_pthread_start
-   fun:thread_start
-}
-{
    bug_16661
    Memcheck:Leak
    fun:_Znwm
@@ -371,6 +383,31 @@
    fun:_ZN11ChildThread4InitEv
 }
 {
+   # Nasty invalid write.  Should we even suppress this?
+   bug_18189
+   Memcheck:Addr8
+   fun:sseCGSFill8by1
+   fun:argb32_mark_constshape
+   fun:argb32_mark
+   fun:ripl_BltShape
+   fun:ripc_Render
+   fun:ripc_DrawRects
+   fun:CGContextFillRects
+   fun:CGContextFillRect
+   fun:NSRectFill
+   fun:-[NSView _drawRect:clip:]
+   fun:-[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:]
+   fun:-[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
+   fun:-[NSNextStepFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
+   fun:-[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:]
+   fun:-[NSView displayIfNeeded]
+   fun:-[NSWindow displayIfNeeded]
+   fun:-[NSWindow _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]
+   fun:-[NSWindow orderWindow:relativeTo:]
+   fun:-[NSWindow addChildWindow:ordered:]
+   fun:_ZN15StatusBubbleMac6CreateEv
+}
+{
    bug_18218
    Memcheck:Leak
    fun:malloc
@@ -395,3 +432,42 @@
    fun:-[TabStripController tabChangedWithContents:atIndex:loadingOnly:]
    fun:_ZN27TabStripModelObserverBridge12TabChangedAtEP11TabContentsib
 }
+{
+   bug_18252
+   Memcheck:Leak
+   fun:calloc
+   fun:_internal_class_createInstanceFromZone
+   fun:_internal_class_createInstance
+   fun:+[NSObject allocWithZone:]
+   fun:+[NSColor colorWithCalibratedRed:green:blue:alpha:]
+   fun:+[GTMTheme(BrowserThemeProviderInitialization) themeWithBrowserThemeProvider:isOffTheRecord:]
+   fun:-[BrowserWindowController(Private) setTheme]
+   fun:-[BrowserWindowController initWithBrowser:takeOwnership:]
+   fun:-[BrowserWindowController initWithBrowser:]
+   fun:_ZN13BrowserWindow19CreateBrowserWindowEP7Browser
+   fun:_ZN7Browser19CreateBrowserWindowEv
+   fun:_ZN7Browser6CreateEP7Profile
+   fun:_ZN7Browser15OpenEmptyWindowEP7Profile
+   fun:_ZN7Browser18NewIncognitoWindowEv
+}
+{
+   bug_18253
+   Memcheck:Cond
+   fun:resample_band
+   fun:img_interpolate_read
+   fun:img_colormatch_read
+   fun:img_data_lock
+   fun:CGSImageDataLock
+   fun:ripc_AcquireImage
+   fun:ripc_DrawImage
+   fun:CGContextDrawImage
+   fun:_ZN7WebCore11BitmapImage4drawEPNS_15GraphicsContextERKNS_9FloatRectES5_NS_17CompositeOperatorE
+   fun:_ZN7WebCore5Image9drawTiledEPNS_15GraphicsContextERKNS_9FloatRectERKNS_10FloatPointERKNS_9FloatSizeENS_17CompositeOperatorE
+   fun:_ZN7WebCore15GraphicsContext14drawTiledImageEPNS_5ImageERKNS_7IntRectERKNS_8IntPointERKNS_7IntSizeENS_17CompositeOperatorE
+   fun:_ZN7WebCore20RenderBoxModelObject22paintFillLayerExtendedERKNS_12RenderObject9PaintInfoERKNS_5ColorEPKNS_9FillLayerEiiiiPNS_13InlineFlowBoxENS_17CompositeOperatorE
+   fun:_ZN7WebCore9RenderBox14paintFillLayerERKNS_12RenderObject9PaintInfoERKNS_5ColorEPKNS_9FillLayerEiiiiNS_17CompositeOperatorE
+   fun:_ZN7WebCore9RenderBox15paintFillLayersERKNS_12RenderObject9PaintInfoERKNS_5ColorEPKNS_9FillLayerEiiiiNS_17CompositeOperatorE
+   fun:_ZN7WebCore9RenderBox19paintBoxDecorationsERNS_12RenderObject9PaintInfoEii
+   fun:_ZN7WebCore11RenderBlock11paintObjectERNS_12RenderObject9PaintInfoEii
+   fun:_ZN7WebCore11RenderBlock5paintERNS_12RenderObject9PaintInfoEii
+}