diff options
| author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-11 20:20:03 +0000 |
|---|---|---|
| committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-11 20:20:03 +0000 |
| commit | c2d6627b362f822cabdd811521a2ca959c0300f6 (patch) | |
| tree | 60713d18ae0a62bf8e48a53f6c0ff7468ffaee42 /tools | |
| parent | 90e1b309ed1e103ba40bd012ad7f8fc137ef31ff (diff) | |
| download | chromium_src-c2d6627b362f822cabdd811521a2ca959c0300f6.zip chromium_src-c2d6627b362f822cabdd811521a2ca959c0300f6.tar.gz chromium_src-c2d6627b362f822cabdd811521a2ca959c0300f6.tar.bz2 | |
Validate hashes based on the legacy device id from M33 on Windows without generally hurting performance.
Introduces a new validation level (VALID_LEGACY_DEVICE_ID) from PrefHashCalculator and a new UMA histogram to go along with it.
The MAC address gathering code is a pure copy/paste from chrome/browser/extensions/api/music_manager_private/device_id_win.cc from an M33 checkout which is the implementation we want to keep around (see bug for a broader duplicate code justification).
BUG=350028
TEST=Run a chrome with this CL against an M33 User Data dir and confirm that every pref reports Settings.TrackedPreferenceUnchangeLegacyDeviceId (except for kExtensionsPref which is initialized to split pref as expected).
R=asvitkine@chromium.org, erikwright@chromium.org
First Committed In: https://src.chromium.org/viewvc/chrome?view=rev&revision=256047
Revert In (XP/Vista unit_tests failure): https://src.chromium.org/viewvc/chrome?view=rev&revision=256069
Review URL: https://codereview.chromium.org/190183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index b0531fd..0e4e8ec 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -18790,6 +18790,16 @@ other types of suffix sets. </summary> </histogram> +<histogram name="Settings.TrackedPreferenceMigratedLegacyDeviceId" + enum="TrackedPreference"> + <summary> + The id of a tracked preference whose value has not changed since the last + time Chrome set it, but which was last set using a legacy device ID. Each + user should report this at most once per preference id and immediately be + migrated to the latest hashing model. + </summary> +</histogram> + <histogram name="Settings.TrackedPreferenceReset" enum="TrackedPreference"> <summary>The id of a tracked preference which was reset by Chrome.</summary> </histogram> |