diff options
| author | tapted@chromium.org <tapted@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 00:43:10 +0000 |
|---|---|---|
| committer | tapted@chromium.org <tapted@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 00:43:10 +0000 |
| commit | 5e115e41109c128c6fe4860efbe9698eca3d692e (patch) | |
| tree | e388529f6b8d093cb22a168d6629204912b7a347 /ui/app_list | |
| parent | bb281f85ccce66e277ff70b1dd82e6419a95ccb3 (diff) | |
| download | chromium_src-5e115e41109c128c6fe4860efbe9698eca3d692e.zip chromium_src-5e115e41109c128c6fe4860efbe9698eca3d692e.tar.gz chromium_src-5e115e41109c128c6fe4860efbe9698eca3d692e.tar.bz2 | |
[Mac] Workaround for Mavericks AppKit accessibility bug in NSCollectionView.
Using the accessibility inspector on the Mac App Launcher in Mavericks
currently causes Chrome to crash. This is due to an AppKit bug that
triggers an unrecognized selector exception to be thrown on
-[NSButtonCell item], inside NSCollectionView code.
This adds a method to the NSButtonCell subclass used by the app launcher
for its NSCollectionView that provides a dummy implementation of the
method AppKit tries to call.
BUG=324365
TEST=Open Mac's Accessibility Inspector, then show the App Launcher.
Hovering over items in the grid should not crash Chrome.
Review URL: https://codereview.chromium.org/96103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238249 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/app_list')
| -rw-r--r-- | ui/app_list/cocoa/apps_grid_view_item.mm | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/ui/app_list/cocoa/apps_grid_view_item.mm b/ui/app_list/cocoa/apps_grid_view_item.mm index ccd6b80..08304da 100644 --- a/ui/app_list/cocoa/apps_grid_view_item.mm +++ b/ui/app_list/cocoa/apps_grid_view_item.mm @@ -458,4 +458,11 @@ void ItemModelObserverBridge::ItemPercentDownloadedChanged() { inView:controlView]; } +// Workaround for http://crbug.com/324365: AppKit in Mavericks tries to call +// - [NSButtonCell item] when inspecting accessibility. Without this, an +// unrecognized selector exception is thrown inside AppKit, crashing Chrome. +- (id)item { + return nil; +} + @end |