diff options
| author | tdresser@chromium.org <tdresser@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-03 21:35:06 +0000 |
|---|---|---|
| committer | tdresser@chromium.org <tdresser@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-03 21:35:06 +0000 |
| commit | d1d067abf68561a23f8bdff954d90fbab73b420a (patch) | |
| tree | e6bfec8daf95b7dc097cb68a5be1ab32ed530ea6 /ui/aura/window.h | |
| parent | 5b597e18292ed8551ad694258cbd3542bdb134cd (diff) | |
| download | chromium_src-d1d067abf68561a23f8bdff954d90fbab73b420a.zip chromium_src-d1d067abf68561a23f8bdff954d90fbab73b420a.tar.gz chromium_src-d1d067abf68561a23f8bdff954d90fbab73b420a.tar.bz2 | |
CHECK that ui::Windows being destroyed have been hidden if necessary
There have been a bunch of crashes due to the GestureRecognizer targeting
touches to windows that have been destroyed. When a window is hidden
(in WindowEventDispatcher::OnWindowHidden), all references to that window
are removed from the GestureRecognizer.
It looks like some windows with touches targeted to them are being
destroyed without being hidden first. This change CHECKs that this
never occurs.
BUG=342040
Review URL: https://codereview.chromium.org/224063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261531 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/aura/window.h')
| -rw-r--r-- | ui/aura/window.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ui/aura/window.h b/ui/aura/window.h index 2324533..6fbea36 100644 --- a/ui/aura/window.h +++ b/ui/aura/window.h @@ -326,6 +326,9 @@ class AURA_EXPORT Window : public ui::LayerDelegate, void PrintWindowHierarchy(int depth) const; #endif + // Returns true if there was state needing to be cleaned up. + bool CleanupGestureState(); + protected: // Deletes (or removes if not owned by parent) all child windows. Intended for // use from the destructor. |