diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 20:21:11 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 20:21:11 +0000 |
| commit | 68eb756608afa95ad18ab4285b2d494431d1c43b (patch) | |
| tree | 6a3f54d308aa77d0c7c00cf864698d547431a927 /ui/aura/window_delegate.h | |
| parent | 290d697955f5a97d067696a63f9c5b166c636c7c (diff) | |
| download | chromium_src-68eb756608afa95ad18ab4285b2d494431d1c43b.zip chromium_src-68eb756608afa95ad18ab4285b2d494431d1c43b.tar.gz chromium_src-68eb756608afa95ad18ab4285b2d494431d1c43b.tar.bz2 | |
Makes OnWindowVisibilityChanged be sent whenever the target visibility
changes. Without this consumers can get confused, and in particular
RWHVA got confused about the state and would think it was hidden when
it wasn't.
BUG=121666
TEST=covered by unit test
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9992004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130999 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/aura/window_delegate.h')
| -rw-r--r-- | ui/aura/window_delegate.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/aura/window_delegate.h b/ui/aura/window_delegate.h index 6247b89..c3b79e2 100644 --- a/ui/aura/window_delegate.h +++ b/ui/aura/window_delegate.h @@ -75,7 +75,10 @@ class AURA_EXPORT WindowDelegate { // The delegate can use this as an opportunity to delete itself if necessary. virtual void OnWindowDestroyed() = 0; - // Called when the visibility of a Window changed. + // Called when the visibility of a Window changes. See description in + // WindowObserver::OnWindowDestroyed() for details. + // TODO: this should be renamed to OnWindowTargetVisibilityChanged() to + // match when it's sent. virtual void OnWindowVisibilityChanged(bool visible) = 0; protected: |