diff options
| author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-22 05:15:46 +0000 |
|---|---|---|
| committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-22 05:15:46 +0000 |
| commit | 5de3bdd5d1a8fb12c1cac3f01246595edde0b66c (patch) | |
| tree | 1097c35a99428ac7583d6d7e6cb5621d1b0dc49d /ui/aura/window_delegate.h | |
| parent | ecddc8229af4246e1bfa234bdd11af7f6c8f7e79 (diff) | |
| download | chromium_src-5de3bdd5d1a8fb12c1cac3f01246595edde0b66c.zip chromium_src-5de3bdd5d1a8fb12c1cac3f01246595edde0b66c.tar.gz chromium_src-5de3bdd5d1a8fb12c1cac3f01246595edde0b66c.tar.bz2 | |
aura: Remove window from its parent a little early.
Remove the window from its parent before calling OnWindowDestroyed callbacks of
the delegate and the observers.
This fixes a couple of failing browser tests.
BUG=none
TEST=browser_tests:IncognitoPopup, DisallowNavigation
Review URL: https://chromiumcodereview.appspot.com/9233027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118641 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/aura/window_delegate.h')
| -rw-r--r-- | ui/aura/window_delegate.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ui/aura/window_delegate.h b/ui/aura/window_delegate.h index e8a3bb3..6247b89 100644 --- a/ui/aura/window_delegate.h +++ b/ui/aura/window_delegate.h @@ -65,12 +65,13 @@ class AURA_EXPORT WindowDelegate { virtual void OnPaint(gfx::Canvas* canvas) = 0; // Called from Window's destructor before OnWindowDestroyed and before the - // children have been destroyed. + // children have been destroyed and the window has been removed from its + // parent. virtual void OnWindowDestroying() = 0; // Called when the Window has been destroyed (i.e. from its destructor). This // is called after OnWindowDestroying and after the children have been - // deleted. + // deleted and the window has been removed from its parent. // The delegate can use this as an opportunity to delete itself if necessary. virtual void OnWindowDestroyed() = 0; |