diff options
author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 12:02:39 +0000 |
---|---|---|
committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 12:02:39 +0000 |
commit | a34edf290367d37ccbfcaf1b21cdbbebb679284a (patch) | |
tree | 53dda0db19b4585bafef8139b7814b1110209d87 /ui/aura/window_observer.h | |
parent | 4958f0d2b68a5881f96d81fc722c915d270305e9 (diff) | |
download | chromium_src-a34edf290367d37ccbfcaf1b21cdbbebb679284a.zip chromium_src-a34edf290367d37ccbfcaf1b21cdbbebb679284a.tar.gz chromium_src-a34edf290367d37ccbfcaf1b21cdbbebb679284a.tar.bz2 |
Revert 178251 - Suspected for CrOS ASAN break
> Situation: There are 5 ways of knowing that the window hierarchy changed.
> This is ridiculous!
> We need to develop one universal standard that covers everyone's use cases.
> Yeah!
> ...
> Situation: There are 6 ways of knowing that the window hierarchy changed.
>
> (source: http://xkcd.com/927/)
>
> Creates a single hierarchy change notification capable of expressing everything all our clients currently need and more (needed for FocusController).
> This adds the notification and the unit tests, I will work on replacing the existing users in a future CL.
>
> BUG=none
> R=sky@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/12042034
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/12040038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178280 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/aura/window_observer.h')
-rw-r--r-- | ui/aura/window_observer.h | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/ui/aura/window_observer.h b/ui/aura/window_observer.h index e519d45..0514c2c 100644 --- a/ui/aura/window_observer.h +++ b/ui/aura/window_observer.h @@ -18,29 +18,6 @@ class Window; class AURA_EXPORT WindowObserver { public: - struct HierarchyChangeParams { - enum HierarchyChangePhase { - HIERARCHY_CHANGING, - HIERARCHY_CHANGED - }; - - Window* target; // The window that was added or removed. - Window* new_parent; - Window* old_parent; - HierarchyChangePhase phase; - Window* receiver; // The window receiving the notification. - }; - - // Called when a window is added or removed. Notifications are sent to the - // following hierarchies in this order: - // 1. |target|. - // 2. |target|'s child hierarchy. - // 3. |target|'s parent hierarchy in its |old_parent|. - // 4. |target|'s parent hierarchy in its |new_parent|. - // This sequence is performed before and after the change is committed, with - // differing values for |phase| in |params| (see above). - virtual void OnWindowHierarchyChange(const HierarchyChangeParams& params) {} - // Invoked when |new_window| has been added as a child of this window. virtual void OnWindowAdded(Window* new_window) {} |