diff options
| author | miletus@chromium.org <miletus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-10 16:47:41 +0000 |
|---|---|---|
| committer | miletus@chromium.org <miletus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-10 16:47:41 +0000 |
| commit | af3aaf09be01987b91fcc4cfcbd682b0d61a6530 (patch) | |
| tree | 953503ce6acf8c41b1d0ae53c40c13460e1cd3a0 /ui/base/gestures | |
| parent | 06ec84a432ccb4c4e00d8a1dd0d03e74c4a7f27c (diff) | |
| download | chromium_src-af3aaf09be01987b91fcc4cfcbd682b0d61a6530.zip chromium_src-af3aaf09be01987b91fcc4cfcbd682b0d61a6530.tar.gz chromium_src-af3aaf09be01987b91fcc4cfcbd682b0d61a6530.tar.bz2 | |
Tuning gesture recognizer parameters
With the Pixel Atmel Touchscreen FW2.0, we get more touch move events
out of the device, which causes the regression that taps are often
misclassified as scroll due to the extra touch moves. This patch
tunes the gesture recognizer parameters to accommodate this:
max_touch_move_in_pixels_for_click : 10 -> 25
min_scroll_successive_velocity_events : 3 -> 4
Also expose the min_scroll_successive_velocity_events parameter to
about://gesture
BUG=284733
TEST=Following the testing instruction in the bug, repeat taps
on the close tab button/new tab button and make sure you don't
miss the taps a lot because of the tap turning into a scroll.
Review URL: https://chromiumcodereview.appspot.com/23735007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222284 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/base/gestures')
| -rw-r--r-- | ui/base/gestures/gesture_configuration.cc | 4 | ||||
| -rw-r--r-- | ui/base/gestures/gesture_configuration.h | 1 |
2 files changed, 2 insertions, 3 deletions
diff --git a/ui/base/gestures/gesture_configuration.cc b/ui/base/gestures/gesture_configuration.cc index 89d09b0..1d1cb73 100644 --- a/ui/base/gestures/gesture_configuration.cc +++ b/ui/base/gestures/gesture_configuration.cc @@ -21,14 +21,14 @@ double double GestureConfiguration::max_swipe_deviation_ratio_ = 3; double GestureConfiguration::max_touch_down_duration_in_seconds_for_click_ = 0.8; -double GestureConfiguration::max_touch_move_in_pixels_for_click_ = 10; +double GestureConfiguration::max_touch_move_in_pixels_for_click_ = 25; double GestureConfiguration::max_distance_between_taps_for_double_tap_ = 20; double GestureConfiguration::min_distance_for_pinch_scroll_in_pixels_ = 20; double GestureConfiguration::min_flick_speed_squared_ = 550.f * 550.f; double GestureConfiguration::min_pinch_update_distance_in_pixels_ = 5; double GestureConfiguration::min_rail_break_velocity_ = 200; double GestureConfiguration::min_scroll_delta_squared_ = 4 * 4; -int GestureConfiguration::min_scroll_successive_velocity_events_ = 3; +int GestureConfiguration::min_scroll_successive_velocity_events_ = 4; float GestureConfiguration::min_scroll_velocity_ = 30.0f; double GestureConfiguration::min_swipe_speed_ = 20; double GestureConfiguration::scroll_prediction_seconds_ = 0.03; diff --git a/ui/base/gestures/gesture_configuration.h b/ui/base/gestures/gesture_configuration.h index 68d2573..3b4df56 100644 --- a/ui/base/gestures/gesture_configuration.h +++ b/ui/base/gestures/gesture_configuration.h @@ -232,7 +232,6 @@ class UI_EXPORT GestureConfiguration { static double min_pinch_update_distance_in_pixels_; static double min_rail_break_velocity_; static double min_scroll_delta_squared_; - // TODO(rjkroege): Expose these in chrome://gesture static int min_scroll_successive_velocity_events_; static float min_scroll_velocity_; static double min_swipe_speed_; |