summaryrefslogtreecommitdiffstats
path: root/ui/base
diff options
context:
space:
mode:
authorthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 12:01:29 +0000
committerthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 12:01:29 +0000
commit4de39f87c85a89046e2bbead1ddd4d6c85e1278c (patch)
tree41c862a438f14947f760c92edc9a70d0aa7215ce /ui/base
parentfb3e985829bde90a71134801d773ad8e1407dda1 (diff)
downloadchromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.zip
chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.gz
chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.bz2
Standardize grit invokes
- Add two gypi files to src/build for the boilerplate added to targets and actions - Update grit_info to also support the -E flag so it can share more of the grit build commandline - switch over all but the webkit and webkit glue grd files to use the common support BUG=22247 TEST=everything still localized correctly Review URL: http://codereview.chromium.org/6705030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/base')
-rw-r--r--ui/base/strings/ui_strings.gyp56
1 files changed, 21 insertions, 35 deletions
diff --git a/ui/base/strings/ui_strings.gyp b/ui/base/strings/ui_strings.gyp
index a561508..257a9da 100644
--- a/ui/base/strings/ui_strings.gyp
+++ b/ui/base/strings/ui_strings.gyp
@@ -1,49 +1,35 @@
{
'variables': {
- # TODO: remove this helper when we have loops in GYP
- 'apply_locales_cmd': ['python', '<(DEPTH)/build/apply_locales.py',],
'chromium_code': 1,
- 'grit_cmd': ['python', '../../../tools/grit/grit.py'],
- 'grit_info_cmd': ['python', '../../../tools/grit/grit_info.py',
- '<@(grit_defines)'],
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/app',
- 'localizable_resources': [
- 'app_locale_settings.grd',
- 'app_strings.grd',
- ],
+ 'grit_base_out_dir': '<(SHARED_INTERMEDIATE_DIR)/app',
},
'targets': [
{
'target_name': 'ui_strings',
'type': 'none',
'msvs_guid': 'BC3C49A3-D061-4E78-84EE-742DA064DC46',
- 'rules': [
+ 'actions': [
{
- 'rule_name': 'grit',
- 'extension': 'grd',
- 'inputs': [
- '<!@(<(grit_info_cmd) --inputs <(localizable_resources))',
- ],
- 'outputs': [
- '<(grit_out_dir)/<(RULE_INPUT_ROOT)/grit/<(RULE_INPUT_ROOT).h',
- # TODO: remove this helper when we have loops in GYP
- '>!@(<(apply_locales_cmd) \'<(grit_out_dir)/<(RULE_INPUT_ROOT)/<(RULE_INPUT_ROOT)_ZZLOCALE.pak\' <(locales))',
- ],
- 'action': [
- '<@(grit_cmd)',
- '-i', '<(RULE_INPUT_PATH)', 'build',
- '-o', '<(grit_out_dir)/<(RULE_INPUT_ROOT)',
- '<@(grit_defines)'],
- 'message': 'Generating resources from <(RULE_INPUT_PATH)',
+ 'action_name': 'app_strings',
+ 'variables': {
+ 'grit_grd_file': 'app_strings.grd',
+ 'grit_out_dir': '<(grit_base_out_dir)/app_strings',
+ },
+ 'includes': [ '../../../build/grit_action.gypi' ],
+ },
+ {
+ 'action_name': 'app_locale_settings',
+ 'variables': {
+ 'grit_grd_file': 'app_locale_settings.grd',
+ 'grit_out_dir': '<(grit_base_out_dir)/app_locale_settings',
+ },
+ 'includes': [ '../../../build/grit_action.gypi' ],
},
- ],
- 'sources': [
- '<@(localizable_resources)',
],
'direct_dependent_settings': {
'include_dirs': [
- '<(grit_out_dir)/app_locale_settings',
- '<(grit_out_dir)/app_strings',
+ '<(grit_base_out_dir)/app_locale_settings',
+ '<(grit_base_out_dir)/app_strings',
],
},
'conditions': [
@@ -66,8 +52,8 @@
'action_name': 'repack_ui_unittest_strings',
'variables': {
'pak_inputs': [
- '<(grit_out_dir)/app_strings/app_strings_en-US.pak',
- '<(grit_out_dir)/app_locale_settings/app_locale_settings_en-US.pak',
+ '<(grit_base_out_dir)/app_strings/app_strings_en-US.pak',
+ '<(grit_base_out_dir)/app_locale_settings/app_locale_settings_en-US.pak',
],
},
'inputs': [
@@ -85,7 +71,7 @@
{
'destination': '<(PRODUCT_DIR)/app_unittests_strings',
'files': [
- '<(grit_out_dir)/app_resources/app_resources.pak',
+ '<(grit_base_out_dir)/app_resources/app_resources.pak',
],
},
],