diff options
author | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 08:52:31 +0000 |
---|---|---|
committer | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 08:52:31 +0000 |
commit | 1a7f42769b898d79643c817cd741d872377fc364 (patch) | |
tree | 0a811d466ba247e8205a9d6c063f112461b536e8 /ui/gfx/icon_util.cc | |
parent | a48610cce51c396e5667b70bce05a5ad80fbc83c (diff) | |
download | chromium_src-1a7f42769b898d79643c817cd741d872377fc364.zip chromium_src-1a7f42769b898d79643c817cd741d872377fc364.tar.gz chromium_src-1a7f42769b898d79643c817cd741d872377fc364.tar.bz2 |
some fixes and warning disables in ui/ for building on win x64
- Some |int|s that should be |ptrdiff_t|s.
- Icon structures are packing to known size (same signs).
- GetWindowLong needs to be GetWindowLongPtr to work on 32 & 64.
R=ben@chromium.org, jschuh@chromium.org
BUG=167187, 166496
Review URL: https://chromiumcodereview.appspot.com/11889017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176860 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/gfx/icon_util.cc')
-rw-r--r-- | ui/gfx/icon_util.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ui/gfx/icon_util.cc b/ui/gfx/icon_util.cc index 5cce7e3..a2f02fb 100644 --- a/ui/gfx/icon_util.cc +++ b/ui/gfx/icon_util.cc @@ -357,8 +357,8 @@ bool IconUtil::CreateIconFileFromSkBitmap(const SkBitmap& bitmap, // If |large_bitmap| was specified, validate its dimension and convert to PNG. scoped_refptr<base::RefCountedMemory> png_bytes; if (!large_bitmap.empty()) { - DCHECK_EQ(256, large_bitmap.width()); - DCHECK_EQ(256, large_bitmap.height()); + CHECK_EQ(256, large_bitmap.width()); + CHECK_EQ(256, large_bitmap.height()); png_bytes = gfx::Image(large_bitmap).As1xPNGBytes(); } @@ -391,7 +391,7 @@ bool IconUtil::CreateIconFileFromSkBitmap(const SkBitmap& bitmap, std::vector<uint8> buffer(buffer_size); ICONDIR* icon_dir = reinterpret_cast<ICONDIR*>(&buffer[0]); icon_dir->idType = kResourceTypeIcon; - icon_dir->idCount = bitmap_count; + icon_dir->idCount = static_cast<WORD>(bitmap_count); size_t icon_dir_count = bitmap_count - 1; // Note DCHECK(!bitmaps.empty())! // Increment counts if a PNG entry will be added. @@ -418,8 +418,8 @@ bool IconUtil::CreateIconFileFromSkBitmap(const SkBitmap& bitmap, entry->bHeight = 0; entry->wPlanes = 1; entry->wBitCount = 32; - entry->dwBytesInRes = png_bytes->size(); - entry->dwImageOffset = offset; + entry->dwBytesInRes = static_cast<DWORD>(png_bytes->size()); + entry->dwImageOffset = static_cast<DWORD>(offset); memcpy(&buffer[offset], png_bytes->front(), png_bytes->size()); offset += png_bytes->size(); } |