diff options
author | benrg@chromium.org <benrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-18 20:35:43 +0000 |
---|---|---|
committer | benrg@chromium.org <benrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-18 20:35:43 +0000 |
commit | 6055415eb77ad8decc67ace1032663c7591ca916 (patch) | |
tree | 5417393227dc5021c9fdfc695b58a0e9b4b0c7ed /ui/gfx/insets.h | |
parent | 133ef817bc668cdec3e9212588fb0f04832ba481 (diff) | |
download | chromium_src-6055415eb77ad8decc67ace1032663c7591ca916.zip chromium_src-6055415eb77ad8decc67ace1032663c7591ca916.tar.gz chromium_src-6055415eb77ad8decc67ace1032663c7591ca916.tar.bz2 |
Preliminary implementation of Google-style dialogs in ash::internal::DialogFrameView
This code is only compiled into Aura and only used if the "Google-style
dialogs" flag is specified (--aura-google-dialog-frames).
Remaining issues:
* Constrained windows are still broken -- see issue 109138.
* Title and body text should be #222, not black. This CL only affects the
title, and currently leaves it at black to match the body text.
* The shadow and border stroke are not up to spec. Fixing this would require
adding new image assets or rewriting the drawing code entirely.
* Some dialogs look pretty bad, such as the certificate viewer (which has
a tab bar with the wrong look).
* The close button placement on medium- and small-sized dialogs may be wrong;
there are no examples in the spec.
* There are sizing/positioning issues with various dialogs (for example, in
Javascript popups the title bar is not always long enough to hold the title).
BUG=none
TEST=none
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/9187061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118136 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/gfx/insets.h')
-rw-r--r-- | ui/gfx/insets.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ui/gfx/insets.h b/ui/gfx/insets.h index 147d58f..9cf5e0a 100644 --- a/ui/gfx/insets.h +++ b/ui/gfx/insets.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -80,6 +80,10 @@ class UI_EXPORT Insets { return *this; } + Insets operator-() const { + return Insets(-top_, -left_, -bottom_, -right_); + } + // Returns a string representation of the insets. std::string ToString() const; |