summaryrefslogtreecommitdiffstats
path: root/ui/gfx/render_text_unittest.cc
diff options
context:
space:
mode:
authordbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-04 06:32:05 +0000
committerdbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-04 06:32:05 +0000
commitfa02121a559929746edbe8710de8af739ae2e484 (patch)
tree3393379fa630c1fc3e83c112a1c060ebed0bd273 /ui/gfx/render_text_unittest.cc
parenta1ce93fef13e2f0bb9c8a48121fe239980ba6b82 (diff)
downloadchromium_src-fa02121a559929746edbe8710de8af739ae2e484.zip
chromium_src-fa02121a559929746edbe8710de8af739ae2e484.tar.gz
chromium_src-fa02121a559929746edbe8710de8af739ae2e484.tar.bz2
Revert 130447 - Use a common font baseline in RenderText classes.
This ensures the text in different runs gets aligned along a common bottom baseline and that the correct font's baseline gets used in case of font fallback. Also, uses the correct height when centering text. BUG=105550 TEST=none Review URL: https://chromiumcodereview.appspot.com/9968040 TBR=asvitkine@chromium.org Review URL: https://chromiumcodereview.appspot.com/9965140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130562 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/gfx/render_text_unittest.cc')
-rw-r--r--ui/gfx/render_text_unittest.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 5769fe1..88ca60f 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -993,27 +993,27 @@ TEST_F(RenderTextTest, CursorBoundsInReplacementMode) {
EXPECT_EQ(cursor_around_b.right(), cursor_before_c.x());
}
-TEST_F(RenderTextTest, OriginForDrawing) {
+TEST_F(RenderTextTest, OriginForSkiaDrawing) {
scoped_ptr<RenderText> render_text(RenderText::CreateRenderText());
render_text->SetText(ASCIIToUTF16("abcdefg"));
render_text->SetFontList(FontList("Arial, 13px"));
// Set display area's height equals to font height.
- const int font_height = render_text->GetStringSize().height();
+ int font_height = render_text->GetFont().GetHeight();
Rect display_rect(0, 0, 100, font_height);
render_text->SetDisplayRect(display_rect);
- Point origin = render_text->GetOriginForDrawing();
+ Point origin = render_text->GetOriginForSkiaDrawing();
EXPECT_EQ(origin.x(), 0);
- EXPECT_EQ(origin.y(), 0);
+ EXPECT_EQ(origin.y(), render_text->GetFont().GetBaseline());
// Set display area's height greater than font height.
display_rect = Rect(0, 0, 100, font_height + 2);
render_text->SetDisplayRect(display_rect);
- origin = render_text->GetOriginForDrawing();
+ origin = render_text->GetOriginForSkiaDrawing();
EXPECT_EQ(origin.x(), 0);
- EXPECT_EQ(origin.y(), 1);
+ EXPECT_EQ(origin.y(), render_text->GetFont().GetBaseline() + 1);
}
TEST_F(RenderTextTest, DisplayRectShowsCursorLTR) {