diff options
author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-27 08:15:57 +0000 |
---|---|---|
committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-27 08:15:57 +0000 |
commit | e53235f54b8629145535d2ef7ba1570f16f51499 (patch) | |
tree | 0bbe59ff88866c999df520ae7f8a5a74a6ec1c27 /ui/gfx | |
parent | eca0b779e81bcfac1afb4b0e7b84e9c910e45584 (diff) | |
download | chromium_src-e53235f54b8629145535d2ef7ba1570f16f51499.zip chromium_src-e53235f54b8629145535d2ef7ba1570f16f51499.tar.gz chromium_src-e53235f54b8629145535d2ef7ba1570f16f51499.tar.bz2 |
Use scoped_ptr for RenderTextTest memory management.
Eliminate heapcheck and valgrind suppressions.
BUG=90370
TEST=none
Review URL: http://codereview.chromium.org/7466043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94257 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/gfx')
-rw-r--r-- | ui/gfx/render_text_unittest.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc index e809d41..26389df 100644 --- a/ui/gfx/render_text_unittest.cc +++ b/ui/gfx/render_text_unittest.cc @@ -4,6 +4,7 @@ #include "ui/gfx/render_text.h" +#include "base/memory/scoped_ptr.h" #include "base/utf_string_conversions.h" #include "testing/gtest/include/gtest/gtest.h" @@ -14,7 +15,7 @@ class RenderTextTest : public testing::Test { TEST_F(RenderTextTest, DefaultStyle) { // Defaults to empty text with no styles. - gfx::RenderText* render_text = gfx::RenderText::CreateRenderText(); + scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText()); EXPECT_TRUE(render_text->text().empty()); EXPECT_TRUE(render_text->style_ranges().empty()); @@ -37,7 +38,7 @@ TEST_F(RenderTextTest, DefaultStyle) { TEST_F(RenderTextTest, CustomDefaultStyle) { // Test a custom default style. - gfx::RenderText* render_text = gfx::RenderText::CreateRenderText(); + scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText()); gfx::StyleRange color; color.foreground = SK_ColorRED; render_text->set_default_style(color); @@ -63,7 +64,7 @@ TEST_F(RenderTextTest, CustomDefaultStyle) { } TEST_F(RenderTextTest, ApplyStyleRange) { - gfx::RenderText* render_text = gfx::RenderText::CreateRenderText(); + scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText()); render_text->SetText(ASCIIToUTF16("01234")); EXPECT_EQ(1U, render_text->style_ranges().size()); @@ -143,7 +144,7 @@ TEST_F(RenderTextTest, ApplyStyleRange) { TEST_F(RenderTextTest, StyleRangesAdjust) { // Test that style ranges adjust to the text size. - gfx::RenderText* render_text = gfx::RenderText::CreateRenderText(); + scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText()); render_text->SetText(ASCIIToUTF16("abcdef")); EXPECT_EQ(1U, render_text->style_ranges().size()); EXPECT_EQ(ui::Range(0, 6), render_text->style_ranges()[0].range); |