diff options
author | dharcourt@chromium.org <dharcourt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-14 18:22:54 +0000 |
---|---|---|
committer | dharcourt@chromium.org <dharcourt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-14 18:22:54 +0000 |
commit | 77a636f66424cf743d8dd2de306b42840bc7d5d3 (patch) | |
tree | 846811dd9581c55d014ddbae5c881996569a7981 /ui/message_center/views/message_view.cc | |
parent | 5e69f25f2f176eab2ae66cb519a7447913b25f21 (diff) | |
download | chromium_src-77a636f66424cf743d8dd2de306b42840bc7d5d3.zip chromium_src-77a636f66424cf743d8dd2de306b42840bc7d5d3.tar.gz chromium_src-77a636f66424cf743d8dd2de306b42840bc7d5d3.tar.bz2 |
Prepared notification views for text line limits.
This involved two changes: 1) How notification views are updated; and
2) How notification views are laid out.
1) Previously notification views were updated by deleting and recreating
all of their subviews. This would be too cumbersome to do with text line
limits because those require notification views to be updated every time
their bounds change (because bounds changes can cause text to go over
or under their line limits and this would require showing or hiding the
expand button). To avoid this problem updating has been changed to
use view hiding/showing (SetVisible()) instead of deletion/recreation.
2) Laying out hidden views was too cumbersome with a GridLayout, so this
was replaced with a couple of easier to deal with BoxLayout subviews.
A side effect of #1 is that expansion buttons are now hidden when they
are not needed. This should be the only user visible change introduced
by this change list as its purpose is just to lay the ground work for
text line limits. Those limits will come in a different change list.
BUG=168939
Review URL: https://chromiumcodereview.appspot.com/12638033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188139 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/message_center/views/message_view.cc')
-rw-r--r-- | ui/message_center/views/message_view.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/ui/message_center/views/message_view.cc b/ui/message_center/views/message_view.cc index b953c63..8e61164 100644 --- a/ui/message_center/views/message_view.cc +++ b/ui/message_center/views/message_view.cc @@ -312,12 +312,6 @@ gfx::Insets MessageView::GetShadowInsets() { kShadowBlur / 2); } -void MessageView::Update(const Notification& notification) { - notification_id_ = notification.id(); - display_source_ = notification.display_source(); - extension_id_ = notification.extension_id(); -} - bool MessageView::OnMousePressed(const ui::MouseEvent& event) { if (event.flags() & ui::EF_RIGHT_MOUSE_BUTTON) { ShowMenu(event.location()); |