diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-07 03:09:00 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-07 03:09:00 +0000 |
| commit | 38d1e3042ce826f717420eea4da56b9e6a5ea1c6 (patch) | |
| tree | d9d43ae8607f7b7daa2bb8dd7eb60289dfa1f7a4 /ui/shell_dialogs | |
| parent | eb769aa29d226c499e9089788b9c992a802bbd71 (diff) | |
| download | chromium_src-38d1e3042ce826f717420eea4da56b9e6a5ea1c6.zip chromium_src-38d1e3042ce826f717420eea4da56b9e6a5ea1c6.tar.gz chromium_src-38d1e3042ce826f717420eea4da56b9e6a5ea1c6.tar.bz2 | |
Fix crash when opening media gallery settings
The return value of SelectFileDialog::Create must be stored in a
scoped_refptr. Updated header comment to make this more clear.
BUG=174552
TEST=manual, see bug
TBR=ben@chromium.org for changing a comment in ui/shell_dialogs
Review URL: https://chromiumcodereview.appspot.com/12209043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181167 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/shell_dialogs')
| -rw-r--r-- | ui/shell_dialogs/select_file_dialog.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ui/shell_dialogs/select_file_dialog.h b/ui/shell_dialogs/select_file_dialog.h index 762e885..8500150 100644 --- a/ui/shell_dialogs/select_file_dialog.h +++ b/ui/shell_dialogs/select_file_dialog.h @@ -89,9 +89,9 @@ class SHELL_DIALOGS_EXPORT SelectFileDialog // a dependency on chrome's extension system.) static void SetFactory(ui::SelectFileDialogFactory* factory); - // Creates a dialog box helper. This object is ref-counted, but the returned - // object will have no reference (refcount is 0). |policy| is an optional - // class that can prevent showing a dialog. + // Creates a dialog box helper. The returned object is ref-counted, starts + // with a ref-count of 0, and should be stored in a scoped_refptr<>. + // |policy| is an optional class that can prevent showing a dialog. static SelectFileDialog* Create(Listener* listener, ui::SelectFilePolicy* policy); |