diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-05 15:19:08 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-05 15:19:08 +0000 |
| commit | a6b2ce64eccc31cf2e8f9b1dd7b90d8c852becee (patch) | |
| tree | 9e68ea211a260c0e73e403562fc3eb59baa3e744 /ui/ui.gyp | |
| parent | 65d5835d4734a3106ef715336a05e4c0b3f9e068 (diff) | |
| download | chromium_src-a6b2ce64eccc31cf2e8f9b1dd7b90d8c852becee.zip chromium_src-a6b2ce64eccc31cf2e8f9b1dd7b90d8c852becee.tar.gz chromium_src-a6b2ce64eccc31cf2e8f9b1dd7b90d8c852becee.tar.bz2 | |
Revert 171223.
Build breakage: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20%28Clang%20dbg%29/builds/25419/steps/compile/logs/stdio
Details:
ui/aura/root_window_host_linux.cc:629:20: error: no matching function for call to 'XIGetProperty'
int result = XIGetProperty(xdisplay_, dev_list[i].deviceid, prop, 0, 0,
^~~~~~~~~~~~~
/usr/include/X11/extensions/XInput2.h:529:1: note: candidate function not viable: no known conversion from 'uint64 *' (aka 'unsigned long long *') to 'unsigned long *' for 10th argument
XIGetProperty(
^
1 error generated.
make: *** [out/Debug/obj.target/aura/ui/aura/root_window_host_linux.o] Error 1
> Handling cursor visibility changing events for ChromeOS
>
> The CL does 5 things:
> 1. A handler in RootWindowHost that will be called whenever cursor
> visibility is changed.
> 2. An utility function in RootWindowHostLinux that can be used to
> set XInput device properties.
> 3. Use 1) and 2) to temporarily pause trackpad tap-to-click feature
> when the cursor is hidden.
> 4. Add a cache class that caches X input device lists to minimize
> round-trip time to X server for device list queries.
> 5. Refactor around the places where XListInputDevices/XIQueryDevice
> queries are used.
>
> Contributed by sheckylin@chromium.org
>
> BUG=chromium:156697,chrome-os-partner:14085
> TEST=Tested on link. "Tap paused" was successfully set when visibility
> changed.
>
> Change-Id: Ia5c62f821c80efc973e3b1ce54a467b674b466a4
>
>
> Review URL: https://chromiumcodereview.appspot.com/11316074
TBR=sheckylin@chromium.org
Review URL: https://codereview.chromium.org/11454002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171225 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/ui.gyp')
| -rw-r--r-- | ui/ui.gyp | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -328,8 +328,6 @@ 'base/x/active_window_watcher_x.cc', 'base/x/active_window_watcher_x.h', 'base/x/active_window_watcher_x_observer.h', - 'base/x/device_list_cache_x.cc', - 'base/x/device_list_cache_x.h', 'base/x/events_x.cc', 'base/x/root_window_property_watcher_x.cc', 'base/x/root_window_property_watcher_x.h', |