diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-14 23:41:11 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-14 23:41:11 +0000 |
| commit | 4b08ef5f5342a9a298766450f00b718d81818176 (patch) | |
| tree | acedff29144898ffd65072d99da7e059c489dc1e /ui/views/PRESUBMIT.py | |
| parent | 6bc688d1136d35e7ea1ae6d47296abce9dee75b5 (diff) | |
| download | chromium_src-4b08ef5f5342a9a298766450f00b718d81818176.zip chromium_src-4b08ef5f5342a9a298766450f00b718d81818176.tar.gz chromium_src-4b08ef5f5342a9a298766450f00b718d81818176.tar.bz2 | |
1. bottom_view_ is removed.
2. dialog content view height calculation is fixed.
The button height calculation in GetPreferredSize(), LayoutContentsView(), and LayoutDialogButtons() do not match.
kButtonVEdgeMargin is missed out in LayoutContentsView() which results in content_view's height is greater than that computed in GetPreferredSize() by kButtonVEdgeMargin.
Subsequently, if there are multiple children Views in the dialog content view (such as JS message box), the spacing between children views (in rows) are not evenly distributed in views::GridLayout::SizeRowsAndColumns().
BUG=127698
TEST=manual test a JS alert with multiple lines, the lines should be evenly spaced. Tested other UI that uses DialogClientView, such as about chromium and bookmark edit, no regression.
Review URL: https://chromiumcodereview.appspot.com/10384064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137011 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/views/PRESUBMIT.py')
0 files changed, 0 insertions, 0 deletions