diff options
| author | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-12 01:57:31 +0000 |
|---|---|---|
| committer | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-12 01:57:31 +0000 |
| commit | b482fe747ceeb396730cd5ca048feff98f2b770c (patch) | |
| tree | 696b9f2073dd4df483ca40d9f93864269b9b490c /ui/views/controls/button/text_button.cc | |
| parent | b818df246a847d9559aab1a2b197a2727ef99f54 (diff) | |
| download | chromium_src-b482fe747ceeb396730cd5ca048feff98f2b770c.zip chromium_src-b482fe747ceeb396730cd5ca048feff98f2b770c.tar.gz chromium_src-b482fe747ceeb396730cd5ca048feff98f2b770c.tar.bz2 | |
Revert 156200 - Conservative update button/label/textfield content
[ RUN ] NativeTextfieldViewsTest.ModelChangesTestLowerCaseWithLocale
controls\textfield\native_textfield_views_unittest.cc(434): error: Value of:
model_->GetText()
Actual: L"\x131"
Expected: WideToUTF16(L"i")
Which is: L"i"
[ FAILED ] NativeTextfieldViewsTest.ModelChangesTestLowerCaseWithLocale (16
ms)
If I had to guess it's that i is considered the same as ı somehow.
Saves a repaint when no change actually occurs.
BUG=chrome-os-partner:13141
TEST=build, run on lumpy, lucas
Change-Id: I6ccb75141b7639571e24b2fbf7e3986d85e98cbc
Review URL: https://chromiumcodereview.appspot.com/10916222
TBR=sheu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156206 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/views/controls/button/text_button.cc')
| -rw-r--r-- | ui/views/controls/button/text_button.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/views/controls/button/text_button.cc b/ui/views/controls/button/text_button.cc index 961c70d..1a4c4e7 100644 --- a/ui/views/controls/button/text_button.cc +++ b/ui/views/controls/button/text_button.cc @@ -291,8 +291,6 @@ void TextButtonBase::SetIsDefault(bool is_default) { } void TextButtonBase::SetText(const string16& text) { - if (text == text_) - return; text_ = text; SetAccessibleName(text); UpdateTextSize(); |