diff options
author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-09 20:53:59 +0000 |
---|---|---|
committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-09 20:53:59 +0000 |
commit | 970451967309a8ab26faaa370fa54ffccec70e24 (patch) | |
tree | 59682eadf710b65237fbc8b01647bcd227371fd8 /ui/views/test/test_views_delegate.h | |
parent | 3f01c469931174046154274c10838f19492efe9d (diff) | |
download | chromium_src-970451967309a8ab26faaa370fa54ffccec70e24.zip chromium_src-970451967309a8ab26faaa370fa54ffccec70e24.tar.gz chromium_src-970451967309a8ab26faaa370fa54ffccec70e24.tar.bz2 |
Ash: Correctly initialize transparency flag for windows
Widgets of TYPE_WINDOW have potentially transparent frames on Ash. I was initializing the transparency flag in the wrong place, leading to a subset of dialogs (edit bookmark, app shortcut, restart chrome, etc.) having black pixels at their outside corners and the wrong appearance in the inactive state. Inspection of the Widget::CreateWindow* callers suggests this is the right place to put this.
BUG=117411
TEST=visual inspection of bookmark windows
Review URL: https://chromiumcodereview.appspot.com/9653011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125894 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/views/test/test_views_delegate.h')
-rw-r--r-- | ui/views/test/test_views_delegate.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ui/views/test/test_views_delegate.h b/ui/views/test/test_views_delegate.h index 5fa952d..99976a2 100644 --- a/ui/views/test/test_views_delegate.h +++ b/ui/views/test/test_views_delegate.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -25,6 +25,8 @@ class TestViewsDelegate : public ViewsDelegate { TestViewsDelegate(); virtual ~TestViewsDelegate(); + void SetUseTransparentWindows(bool transparent); + // Overridden from ViewsDelegate: virtual ui::Clipboard* GetClipboard() const OVERRIDE; virtual void SaveWindowPlacement(const Widget* window, @@ -51,6 +53,7 @@ class TestViewsDelegate : public ViewsDelegate { #endif virtual NonClientFrameView* CreateDefaultNonClientFrameView( Widget* widget) OVERRIDE; + virtual bool UseTransparentWindows() const OVERRIDE; virtual void AddRef() OVERRIDE {} virtual void ReleaseRef() OVERRIDE {} @@ -58,6 +61,7 @@ class TestViewsDelegate : public ViewsDelegate { private: mutable scoped_ptr<ui::Clipboard> clipboard_; + bool use_transparent_windows_; DISALLOW_COPY_AND_ASSIGN(TestViewsDelegate); }; |