summaryrefslogtreecommitdiffstats
path: root/ui/views
diff options
context:
space:
mode:
authoryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-13 17:38:03 +0000
committeryusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-13 17:38:03 +0000
commit9ec9018bc727f4f6169e745dbb0decc4dad248eb (patch)
tree3410e1b57fd59e7da7a849423ccd46037b6469c8 /ui/views
parenta049b24a30811754b47b6f81dbd4e35b54617b70 (diff)
downloadchromium_src-9ec9018bc727f4f6169e745dbb0decc4dad248eb.zip
chromium_src-9ec9018bc727f4f6169e745dbb0decc4dad248eb.tar.gz
chromium_src-9ec9018bc727f4f6169e745dbb0decc4dad248eb.tar.bz2
Make destructors of classes that implement aura::WindowDelegate private or protected.
This would be better since an instance of these classes shouldn't be deleted directly. BUG=None TEST=try Review URL: https://chromiumcodereview.appspot.com/10545108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141904 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/views')
-rw-r--r--ui/views/widget/native_widget_aura.cc17
-rw-r--r--ui/views/widget/native_widget_aura.h3
2 files changed, 12 insertions, 8 deletions
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 67254d1..8728811 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -153,13 +153,6 @@ NativeWidgetAura::NativeWidgetAura(internal::NativeWidgetDelegate* delegate)
saved_window_state_(ui::SHOW_STATE_DEFAULT) {
}
-NativeWidgetAura::~NativeWidgetAura() {
- if (ownership_ == Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET)
- delete delegate_;
- else
- CloseNow();
-}
-
// static
gfx::Font NativeWidgetAura::GetWindowTitleFont() {
#if defined(OS_WIN)
@@ -867,6 +860,16 @@ int NativeWidgetAura::OnPerformDrop(const aura::DropTargetEvent& event) {
}
////////////////////////////////////////////////////////////////////////////////
+// NativeWidgetAura, protected:
+
+NativeWidgetAura::~NativeWidgetAura() {
+ if (ownership_ == Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET)
+ delete delegate_;
+ else
+ CloseNow();
+}
+
+////////////////////////////////////////////////////////////////////////////////
// NativeWidgetAura, private:
void NativeWidgetAura::SetInitialFocus() {
diff --git a/ui/views/widget/native_widget_aura.h b/ui/views/widget/native_widget_aura.h
index 1907e08..d299c85 100644
--- a/ui/views/widget/native_widget_aura.h
+++ b/ui/views/widget/native_widget_aura.h
@@ -34,7 +34,6 @@ class VIEWS_EXPORT NativeWidgetAura : public internal::NativeWidgetPrivate,
public aura::client::DragDropDelegate {
public:
explicit NativeWidgetAura(internal::NativeWidgetDelegate* delegate);
- virtual ~NativeWidgetAura();
// TODO(beng): Find a better place for this, and the similar method on
// NativeWidgetWin.
@@ -160,6 +159,8 @@ class VIEWS_EXPORT NativeWidgetAura : public internal::NativeWidgetPrivate,
virtual int OnPerformDrop(const aura::DropTargetEvent& event) OVERRIDE;
protected:
+ virtual ~NativeWidgetAura();
+
internal::NativeWidgetDelegate* delegate() { return delegate_; }
private: