diff options
| author | dpapad@chromium.org <dpapad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 20:47:22 +0000 |
|---|---|---|
| committer | dpapad@chromium.org <dpapad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-11 20:47:22 +0000 |
| commit | 37cbcfeb1c02033b2785c7aeb321f99ad9f65821 (patch) | |
| tree | e83848800dc5cd5477e3480dbff3166ead14750f /ui | |
| parent | 3b6ea292868e9677ac4261235e7a8c82e1e177d8 (diff) | |
| download | chromium_src-37cbcfeb1c02033b2785c7aeb321f99ad9f65821.zip chromium_src-37cbcfeb1c02033b2785c7aeb321f99ad9f65821.tar.gz chromium_src-37cbcfeb1c02033b2785c7aeb321f99ad9f65821.tar.bz2 | |
Coverity PASS_BY_VALUE bug fixes
BUG=CIDs 8731,9102,15473,6809
TEST=NONE
Review URL: http://codereview.chromium.org/6670025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77854 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/base/x/x11_util.cc | 2 | ||||
| -rw-r--r-- | ui/base/x/x11_util_internal.h | 2 | ||||
| -rw-r--r-- | ui/gfx/skbitmap_operations.cc | 2 | ||||
| -rw-r--r-- | ui/gfx/skbitmap_operations.h | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/ui/base/x/x11_util.cc b/ui/base/x/x11_util.cc index 6234069..f7c9c26 100644 --- a/ui/base/x/x11_util.cc +++ b/ui/base/x/x11_util.cc @@ -828,7 +828,7 @@ void SetX11ErrorHandlers(XErrorHandler error_handler, } void LogErrorEventDescription(Display* dpy, - XErrorEvent error_event) { + const XErrorEvent& error_event) { char error_str[256]; char request_str[256]; diff --git a/ui/base/x/x11_util_internal.h b/ui/base/x/x11_util_internal.h index 87b75ef8..31bbab2 100644 --- a/ui/base/x/x11_util_internal.h +++ b/ui/base/x/x11_util_internal.h @@ -44,7 +44,7 @@ namespace ui { // X11 Error handler because it queries the server to decode the // error message, which may trigger other errors. A suitable workaround // is to post a task in the error handler to call this function. - void LogErrorEventDescription(Display* dpy, XErrorEvent error_event); + void LogErrorEventDescription(Display* dpy, const XErrorEvent& error_event); } // namespace ui diff --git a/ui/gfx/skbitmap_operations.cc b/ui/gfx/skbitmap_operations.cc index d3b4d8c..7cd7122 100644 --- a/ui/gfx/skbitmap_operations.cc +++ b/ui/gfx/skbitmap_operations.cc @@ -507,7 +507,7 @@ const LineProcessor kLineProcessors[kNumHOps][kNumSOps][kNumLOps] = { // static SkBitmap SkBitmapOperations::CreateHSLShiftedBitmap( const SkBitmap& bitmap, - color_utils::HSL hsl_shift) { + const color_utils::HSL& hsl_shift) { // Default to NOPs. HSLShift::OperationOnH H_op = HSLShift::kOpHNone; HSLShift::OperationOnS S_op = HSLShift::kOpSNone; diff --git a/ui/gfx/skbitmap_operations.h b/ui/gfx/skbitmap_operations.h index cde09cb..dce8e3c 100644 --- a/ui/gfx/skbitmap_operations.h +++ b/ui/gfx/skbitmap_operations.h @@ -62,7 +62,7 @@ class SkBitmapOperations { // 0.5 = leave unchanged. // 1 = full lightness (make all pixels white). static SkBitmap CreateHSLShiftedBitmap(const SkBitmap& bitmap, - color_utils::HSL hsl_shift); + const color_utils::HSL& hsl_shift); // Create a bitmap that is cropped from another bitmap. This is special // because it tiles the original bitmap, so your coordinates can extend |