diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 19:05:42 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 19:05:42 +0000 |
| commit | bde1160adae6d55fc12d781d5da667a92865d6d4 (patch) | |
| tree | e7e38ac67b502ba8b4964b7e6771b4c5ef08da14 /ui | |
| parent | 652f443deb310d2232bdbf49247e3fee27e4fb7c (diff) | |
| download | chromium_src-bde1160adae6d55fc12d781d5da667a92865d6d4.zip chromium_src-bde1160adae6d55fc12d781d5da667a92865d6d4.tar.gz chromium_src-bde1160adae6d55fc12d781d5da667a92865d6d4.tar.bz2 | |
Fix unsafe infobar usage pattern in ExtensionDevToolsClientHost. Listening for infobar deletion to determine when it's appropriate to remove an infobar from the InfoBarTabHelper doesn't work correctly in two cases: (1) when the infobar is in the midst of closing (when it's already unowned but not yet deleted) and (2) if it's leaked due to being closed while in a background tab (will be fixed someday by refactoring changes I'm still waiting to land).
Also safely handle the case of AddInfoBar() failing, by plumbing a return code back.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10264025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135383 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
0 files changed, 0 insertions, 0 deletions