summaryrefslogtreecommitdiffstats
path: root/ui
diff options
context:
space:
mode:
authoryoichio@chromium.org <yoichio@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-08-29 16:36:40 +0000
committeryoichio@chromium.org <yoichio@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-08-29 16:36:40 +0000
commitceb15f78acfdc065a2d4f851ebedd47e7a885c49 (patch)
tree89c7a0a7c779afd4600af26a84c98675488bf0c8 /ui
parent6efc38958e00bd6a0c5daf07dc769cf89786cc0a (diff)
downloadchromium_src-ceb15f78acfdc065a2d4f851ebedd47e7a885c49.zip
chromium_src-ceb15f78acfdc065a2d4f851ebedd47e7a885c49.tar.gz
chromium_src-ceb15f78acfdc065a2d4f851ebedd47e7a885c49.tar.bz2
Add InputMethod::GetTextInputMode
It retuns clients' input mode if clients is focused. BUG=244688 Review URL: https://chromiumcodereview.appspot.com/23751002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220318 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
-rw-r--r--ui/base/ime/dummy_input_method.cc4
-rw-r--r--ui/base/ime/dummy_input_method.h1
-rw-r--r--ui/base/ime/fake_input_method.cc8
-rw-r--r--ui/base/ime/fake_input_method.h3
-rw-r--r--ui/base/ime/input_method.h9
-rw-r--r--ui/base/ime/input_method_base.cc5
-rw-r--r--ui/base/ime/input_method_base.h1
-rw-r--r--ui/base/ime/mock_input_method.cc8
-rw-r--r--ui/base/ime/mock_input_method.h1
9 files changed, 35 insertions, 5 deletions
diff --git a/ui/base/ime/dummy_input_method.cc b/ui/base/ime/dummy_input_method.cc
index f762e3b..b9f6941 100644
--- a/ui/base/ime/dummy_input_method.cc
+++ b/ui/base/ime/dummy_input_method.cc
@@ -72,6 +72,10 @@ TextInputType DummyInputMethod::GetTextInputType() const {
return TEXT_INPUT_TYPE_NONE;
}
+TextInputMode DummyInputMethod::GetTextInputMode() const {
+ return TEXT_INPUT_MODE_DEFAULT;
+}
+
bool DummyInputMethod::CanComposeInline() const {
return true;
}
diff --git a/ui/base/ime/dummy_input_method.h b/ui/base/ime/dummy_input_method.h
index 2276ae5..165bc52 100644
--- a/ui/base/ime/dummy_input_method.h
+++ b/ui/base/ime/dummy_input_method.h
@@ -36,6 +36,7 @@ class DummyInputMethod : public InputMethod {
virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;
virtual bool IsActive() OVERRIDE;
virtual TextInputType GetTextInputType() const OVERRIDE;
+ virtual TextInputMode GetTextInputMode() const OVERRIDE;
virtual bool CanComposeInline() const OVERRIDE;
virtual bool IsCandidatePopupOpen() const OVERRIDE;
virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;
diff --git a/ui/base/ime/fake_input_method.cc b/ui/base/ime/fake_input_method.cc
index 1cf236d..15f1283 100644
--- a/ui/base/ime/fake_input_method.cc
+++ b/ui/base/ime/fake_input_method.cc
@@ -141,8 +141,12 @@ bool FakeInputMethod::IsCandidatePopupOpen() const {
return false;
}
-ui::TextInputType FakeInputMethod::GetTextInputType() const {
- return ui::TEXT_INPUT_TYPE_NONE;
+TextInputType FakeInputMethod::GetTextInputType() const {
+ return TEXT_INPUT_TYPE_NONE;
+}
+
+TextInputMode FakeInputMethod::GetTextInputMode() const {
+ return TEXT_INPUT_MODE_DEFAULT;
}
bool FakeInputMethod::CanComposeInline() const {
diff --git a/ui/base/ime/fake_input_method.h b/ui/base/ime/fake_input_method.h
index 12f9aac..e80d2bc 100644
--- a/ui/base/ime/fake_input_method.h
+++ b/ui/base/ime/fake_input_method.h
@@ -44,7 +44,8 @@ class UI_EXPORT FakeInputMethod : NON_EXPORTED_BASE(public InputMethod) {
virtual std::string GetInputLocale() OVERRIDE;
virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;
virtual bool IsActive() OVERRIDE;
- virtual ui::TextInputType GetTextInputType() const OVERRIDE;
+ virtual TextInputType GetTextInputType() const OVERRIDE;
+ virtual TextInputMode GetTextInputMode() const OVERRIDE;
virtual bool CanComposeInline() const OVERRIDE;
virtual bool IsCandidatePopupOpen() const OVERRIDE;
virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;
diff --git a/ui/base/ime/input_method.h b/ui/base/ime/input_method.h
index 575cbcd..0d4046f 100644
--- a/ui/base/ime/input_method.h
+++ b/ui/base/ime/input_method.h
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/event_types.h"
#include "base/i18n/rtl.h"
+#include "ui/base/ime/text_input_mode.h"
#include "ui/base/ime/text_input_type.h"
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/ui_export.h"
@@ -140,10 +141,18 @@ class InputMethod {
// is not active.
virtual bool IsActive() = 0;
+ // TODO(yoichio): Following 3 methods(GetTextInputType, GetTextInputMode and
+ // CanComposeInline) calls client's same method and returns its value. It is
+ // not InputMethod itself's infomation. So rename these to
+ // GetClientTextInputType and so on.
// Gets the text input type of the focused text input client. Returns
// ui::TEXT_INPUT_TYPE_NONE if there is no focused client.
virtual TextInputType GetTextInputType() const = 0;
+ // Gets the text input mode of the focused text input client. Returns
+ // ui::TEXT_INPUT_TYPE_DEFAULT if there is no focused client.
+ virtual TextInputMode GetTextInputMode() const = 0;
+
// Checks if the focused text input client supports inline composition.
virtual bool CanComposeInline() const = 0;
diff --git a/ui/base/ime/input_method_base.cc b/ui/base/ime/input_method_base.cc
index 6972eed..23d21ba 100644
--- a/ui/base/ime/input_method_base.cc
+++ b/ui/base/ime/input_method_base.cc
@@ -67,6 +67,11 @@ TextInputType InputMethodBase::GetTextInputType() const {
return client ? client->GetTextInputType() : TEXT_INPUT_TYPE_NONE;
}
+TextInputMode InputMethodBase::GetTextInputMode() const {
+ TextInputClient* client = GetTextInputClient();
+ return client ? client->GetTextInputMode() : TEXT_INPUT_MODE_DEFAULT;
+}
+
bool InputMethodBase::CanComposeInline() const {
TextInputClient* client = GetTextInputClient();
return client ? client->CanComposeInline() : true;
diff --git a/ui/base/ime/input_method_base.h b/ui/base/ime/input_method_base.h
index e467e0b..655fd4a 100644
--- a/ui/base/ime/input_method_base.h
+++ b/ui/base/ime/input_method_base.h
@@ -44,6 +44,7 @@ class UI_EXPORT InputMethodBase : NON_EXPORTED_BASE(public InputMethod) {
virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;
virtual TextInputType GetTextInputType() const OVERRIDE;
+ virtual TextInputMode GetTextInputMode() const OVERRIDE;
virtual bool CanComposeInline() const OVERRIDE;
virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;
diff --git a/ui/base/ime/mock_input_method.cc b/ui/base/ime/mock_input_method.cc
index 7701b5c..aed83c2 100644
--- a/ui/base/ime/mock_input_method.cc
+++ b/ui/base/ime/mock_input_method.cc
@@ -83,8 +83,12 @@ bool MockInputMethod::IsActive() {
return true;
}
-ui::TextInputType MockInputMethod::GetTextInputType() const {
- return ui::TEXT_INPUT_TYPE_NONE;
+TextInputType MockInputMethod::GetTextInputType() const {
+ return TEXT_INPUT_TYPE_NONE;
+}
+
+TextInputMode MockInputMethod::GetTextInputMode() const {
+ return TEXT_INPUT_MODE_DEFAULT;
}
bool MockInputMethod::CanComposeInline() const {
diff --git a/ui/base/ime/mock_input_method.h b/ui/base/ime/mock_input_method.h
index f318ca4..fdeff5e 100644
--- a/ui/base/ime/mock_input_method.h
+++ b/ui/base/ime/mock_input_method.h
@@ -60,6 +60,7 @@ class UI_EXPORT MockInputMethod : NON_EXPORTED_BASE(public InputMethod) {
virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;
virtual bool IsActive() OVERRIDE;
virtual TextInputType GetTextInputType() const OVERRIDE;
+ virtual TextInputMode GetTextInputMode() const OVERRIDE;
virtual bool CanComposeInline() const OVERRIDE;
virtual bool IsCandidatePopupOpen() const OVERRIDE;
virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;