summaryrefslogtreecommitdiffstats
path: root/ui
diff options
context:
space:
mode:
authorspang@chromium.org <spang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-21 11:13:35 +0000
committerspang@chromium.org <spang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-21 11:13:35 +0000
commit751dbd5dc837671914f4c6d0b0fca8aa027e8cf9 (patch)
treefb58d95e86b3204126098357c344ae7ee74719f3 /ui
parent2757b474f6ecc34e6fde167286962e22ba703491 (diff)
downloadchromium_src-751dbd5dc837671914f4c6d0b0fca8aa027e8cf9.zip
chromium_src-751dbd5dc837671914f4c6d0b0fca8aa027e8cf9.tar.gz
chromium_src-751dbd5dc837671914f4c6d0b0fca8aa027e8cf9.tar.bz2
ozone: evdev: Avoid unnecessary log message building
If verbosity is turned down, then VLOG() turns into a no-op. We can't take advantage of this if we build the message ahead of time. BUG=none TEST=build Review URL: https://codereview.chromium.org/206483006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258519 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
-rw-r--r--ui/events/ozone/evdev/device_manager_udev.cc8
1 files changed, 3 insertions, 5 deletions
diff --git a/ui/events/ozone/evdev/device_manager_udev.cc b/ui/events/ozone/evdev/device_manager_udev.cc
index 686dc9d..de7b29d 100644
--- a/ui/events/ozone/evdev/device_manager_udev.cc
+++ b/ui/events/ozone/evdev/device_manager_udev.cc
@@ -42,14 +42,12 @@ void UdevLog(struct udev* udev,
const char* fn,
const char* format,
va_list args) {
- std::string message = base::StringPrintf("libudev: %s: ", fn);
- base::StringAppendV(&message, format, args);
if (priority <= SYS_LOG_ERR)
- LOG(ERROR) << message;
+ LOG(ERROR) << "libudev: " << fn << ": " << base::StringPrintV(format, args);
else if (priority <= SYS_LOG_INFO)
- VLOG(1) << message;
+ VLOG(1) << "libudev: " << fn << ": " << base::StringPrintV(format, args);
else // SYS_LOG_DEBUG
- VLOG(2) << message;
+ VLOG(2) << "libudev: " << fn << ": " << base::StringPrintV(format, args);
}
// Create libudev context.