diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-07 21:40:35 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-07 21:40:35 +0000 |
commit | a2e6af1853d23b82a87b4ae6554424cc6e5393fb (patch) | |
tree | ce0517e27e276e014f7cbec6ecc662c6f064a83d /ui | |
parent | 7a97aa864a3f602b4c032d3088df79528d69454f (diff) | |
download | chromium_src-a2e6af1853d23b82a87b4ae6554424cc6e5393fb.zip chromium_src-a2e6af1853d23b82a87b4ae6554424cc6e5393fb.tar.gz chromium_src-a2e6af1853d23b82a87b4ae6554424cc6e5393fb.tar.bz2 |
Continue threading context through unit tests.
- views_unittest now passes with the assert that checks that we have context.
- ash_unittest...is making progress towards that and this patch is already big.
BUG=161882
Review URL: https://codereview.chromium.org/11795004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175389 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
-rw-r--r-- | ui/views/test/child_modal_window.cc | 13 | ||||
-rw-r--r-- | ui/views/test/child_modal_window.h | 4 | ||||
-rw-r--r-- | ui/views/view_unittest.cc | 2 | ||||
-rw-r--r-- | ui/views/widget/widget_unittest.cc | 10 |
4 files changed, 16 insertions, 13 deletions
diff --git a/ui/views/test/child_modal_window.cc b/ui/views/test/child_modal_window.cc index b3e072a..ebf1ac2 100644 --- a/ui/views/test/child_modal_window.cc +++ b/ui/views/test/child_modal_window.cc @@ -45,9 +45,10 @@ const SkColor kChildColor = SK_ColorWHITE; } // namespace -void CreateChildModalParent() { - Widget::CreateWindowWithBounds( - new ChildModalParent, +void CreateChildModalParent(gfx::NativeView context) { + Widget::CreateWindowWithContextAndBounds( + new ChildModalParent(context), + context, gfx::Rect(kWindowLeft, kWindowTop, kWindowWidth, kWindowHeight))->Show(); } @@ -106,7 +107,7 @@ ui::ModalType ChildModalWindow::GetModalType() const { return ui::MODAL_TYPE_CHILD; } -ChildModalParent::ChildModalParent() +ChildModalParent::ChildModalParent(gfx::NativeView context) : ALLOW_THIS_IN_INITIALIZER_LIST(button_(new NativeTextButton( this, ASCIIToUTF16("Show/Hide Child Modal Window")))), textfield_(new Textfield), @@ -114,7 +115,9 @@ ChildModalParent::ChildModalParent() modal_parent_(NULL), child_(NULL) { Widget* widget = new Widget; - widget->Init(Widget::InitParams(Widget::InitParams::TYPE_CONTROL)); + Widget::InitParams params(Widget::InitParams::TYPE_CONTROL); + params.context = context; + widget->Init(params); widget->GetRootView()->set_background( Background::CreateSolidBackground(kModalParentColor)); modal_parent_ = widget->GetNativeView(); diff --git a/ui/views/test/child_modal_window.h b/ui/views/test/child_modal_window.h index f7fb8cb..455df7c 100644 --- a/ui/views/test/child_modal_window.h +++ b/ui/views/test/child_modal_window.h @@ -17,13 +17,13 @@ class View; class Widget; namespace test { -void CreateChildModalParent(); +void CreateChildModalParent(gfx::NativeView context); class ChildModalParent : public WidgetDelegateView, public ButtonListener, public WidgetObserver { public: - ChildModalParent(); + ChildModalParent(gfx::NativeView context); virtual ~ChildModalParent(); void ShowChild(); diff --git a/ui/views/view_unittest.cc b/ui/views/view_unittest.cc index e819d14..293510f 100644 --- a/ui/views/view_unittest.cc +++ b/ui/views/view_unittest.cc @@ -840,7 +840,7 @@ TEST_F(ViewTest, DISABLED_Painting) { TEST_F(ViewTest, RemoveNotification) { ViewStorage* vs = ViewStorage::GetInstance(); Widget* widget = new Widget; - widget->Init(Widget::InitParams(Widget::InitParams::TYPE_POPUP)); + widget->Init(CreateParams(Widget::InitParams::TYPE_POPUP)); View* root_view = widget->GetRootView(); View* v1 = new View; diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc index 59d49be..b8bb6c6 100644 --- a/ui/views/widget/widget_unittest.cc +++ b/ui/views/widget/widget_unittest.cc @@ -612,7 +612,7 @@ TEST_F(WidgetOwnershipTest, Ownership_PlatformNativeWidgetOwnsWidget) { OwnershipTestState state; Widget* widget = new OwnershipTestWidget(&state); - Widget::InitParams params(Widget::InitParams::TYPE_POPUP); + Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP); params.native_widget = new OwnershipTestNativeWidgetPlatform(widget, &state); widget->Init(params); @@ -631,7 +631,7 @@ TEST_F(WidgetOwnershipTest, Ownership_ViewsNativeWidgetOwnsWidget) { Widget* toplevel = CreateTopLevelPlatformWidget(); Widget* widget = new OwnershipTestWidget(&state); - Widget::InitParams params(Widget::InitParams::TYPE_POPUP); + Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP); params.native_widget = new OwnershipTestNativeWidgetPlatform(widget, &state); params.parent = toplevel->GetNativeView(); @@ -655,7 +655,7 @@ TEST_F(WidgetOwnershipTest, OwnershipTestState state; Widget* widget = new OwnershipTestWidget(&state); - Widget::InitParams params(Widget::InitParams::TYPE_POPUP); + Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP); params.native_widget = new OwnershipTestNativeWidgetPlatform(widget, &state); widget->Init(params); @@ -680,7 +680,7 @@ TEST_F(WidgetOwnershipTest, Widget* toplevel = CreateTopLevelPlatformWidget(); Widget* widget = new OwnershipTestWidget(&state); - Widget::InitParams params(Widget::InitParams::TYPE_POPUP); + Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP); params.native_widget = new OwnershipTestNativeWidgetPlatform(widget, &state); params.parent = toplevel->GetNativeView(); @@ -706,7 +706,7 @@ TEST_F(WidgetOwnershipTest, Widget* toplevel = CreateTopLevelPlatformWidget(); Widget* widget = new OwnershipTestWidget(&state); - Widget::InitParams params(Widget::InitParams::TYPE_POPUP); + Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP); params.native_widget = new OwnershipTestNativeWidgetPlatform(widget, &state); params.parent = toplevel->GetNativeView(); |