diff options
| author | yusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-24 17:17:19 +0000 |
|---|---|---|
| committer | yusukes@chromium.org <yusukes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-24 17:17:19 +0000 |
| commit | 3d0824177f14eba2dbc775dc35ea9c5a5cac1f0f (patch) | |
| tree | 240025d613aecb33803fdeac3b39f54667eeca8d /ui | |
| parent | f7f9819d66ea030ff43ca813ee87828cfce1fa29 (diff) | |
| download | chromium_src-3d0824177f14eba2dbc775dc35ea9c5a5cac1f0f.zip chromium_src-3d0824177f14eba2dbc775dc35ea9c5a5cac1f0f.tar.gz chromium_src-3d0824177f14eba2dbc775dc35ea9c5a5cac1f0f.tar.bz2 | |
Do not send an IBus IPC message for updating a cursor location.
Currently, every time the location of the input cursor in Chrome changes, ui::InputMethodIBus sends an IPC message to ibus-daemon by calling ibus_input_context_set_cursor_location API so that the IME candidate window could be shown in a proper position. However, the IPC is actually unnecessary since the candidate window is shown by the Chrome browser process itself. Instead of the IPC, we should update member variables in chromeos::input_method::IBusUiControllerImpl.
BUG=chromium-os:25332
TEST=try
Review URL: http://codereview.chromium.org/9241033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118851 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/base/ime/input_method_ibus.h | 7 | ||||
| -rw-r--r-- | ui/base/ime/input_method_ibus_unittest.cc | 1 |
2 files changed, 3 insertions, 5 deletions
diff --git a/ui/base/ime/input_method_ibus.h b/ui/base/ime/input_method_ibus.h index 30f7e90..23dbd22 100644 --- a/ui/base/ime/input_method_ibus.h +++ b/ui/base/ime/input_method_ibus.h @@ -46,15 +46,14 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase { virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE; virtual bool IsActive() OVERRIDE; - protected: // Sets |new_client| as a new IBusClient. InputMethodIBus owns the object. - // This method has to be called before InputMethodIBus::Init() is called. - // Protected: for testing. + // A client has to be set before InputMethodIBus::Init() is called. void set_ibus_client(scoped_ptr<internal::IBusClient> new_client); - // Protected: for testing. The caller is not allowed to deleted the object. + // The caller is not allowed to delete the object. internal::IBusClient* ibus_client() const; + protected: // Returns the global IBusBus instance. Protected: for testing. IBusBus* GetBus(); diff --git a/ui/base/ime/input_method_ibus_unittest.cc b/ui/base/ime/input_method_ibus_unittest.cc index a2afc40..39f8e45 100644 --- a/ui/base/ime/input_method_ibus_unittest.cc +++ b/ui/base/ime/input_method_ibus_unittest.cc @@ -25,7 +25,6 @@ class TestableInputMethodIBus : public InputMethodIBus { } // Change access rights. - using InputMethodIBus::ibus_client; using InputMethodIBus::GetBus; }; |