diff options
| author | brettw <brettw@chromium.org> | 2015-02-19 15:17:04 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-19 23:18:14 +0000 |
| commit | d1c719acf7db459016f425eb8018ec4208511578 (patch) | |
| tree | f5604ba0055245c0133cd5747e8a70de99b917f7 /url | |
| parent | 9ff250e0023b2f87e0fddd7eadbef7be3ecc3882 (diff) | |
| download | chromium_src-d1c719acf7db459016f425eb8018ec4208511578.zip chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.gz chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.bz2 | |
Update existing uses of /wd4267 to use the GN config
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
Diffstat (limited to 'url')
| -rw-r--r-- | url/BUILD.gn | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/url/BUILD.gn b/url/BUILD.gn index 03e90cb..964a08b 100644 --- a/url/BUILD.gn +++ b/url/BUILD.gn @@ -58,11 +58,11 @@ component("url") { defines = [ "URL_IMPLEMENTATION" ] - configs += [ ":url_icu_config" ] - - if (is_win) { - cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - } + configs += [ + ":url_icu_config", + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + "//build/config/compiler:no_size_t_to_int_warning", + ] deps = [ "//base", @@ -101,19 +101,15 @@ if (!is_android) { "url_util_unittest.cc", ] + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] + #if (is_posix && !is_mac && !is_ios) { # if (use_allocator!="none") { # deps += "//base/allocator" # } #} - if (is_win) { - cflags = [ - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - "/wd4267", - ] - } - deps = [ ":url", "//base", |