diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 17:40:13 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 17:40:13 +0000 |
commit | cec6c9c550f44741c7acacfd5d3f67e919110c4c (patch) | |
tree | f6778f4a10b1aa5b0a7b74526c632377214703b1 /views/controls/button | |
parent | 210796e7c8207e56dae29392b62e1e79ec9f837f (diff) | |
download | chromium_src-cec6c9c550f44741c7acacfd5d3f67e919110c4c.zip chromium_src-cec6c9c550f44741c7acacfd5d3f67e919110c4c.tar.gz chromium_src-cec6c9c550f44741c7acacfd5d3f67e919110c4c.tar.bz2 |
See original review at
http://codereview.chromium.org/251001/show
This CL hooks the focus traversal for the TabbedPaneView on Linux with toolkit views.
It also has few focus related fixed (focus with buttons, clearing focus effectively in the focus manager).
BUG=None
TEST=Run the view_examples app. Press tab to move the focus. Try the different tabs.
Review URL: http://codereview.chromium.org/246030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27504 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/controls/button')
-rw-r--r-- | views/controls/button/button.cc | 1 | ||||
-rw-r--r-- | views/controls/button/native_button.cc | 2 | ||||
-rw-r--r-- | views/controls/button/text_button.cc | 1 |
3 files changed, 2 insertions, 2 deletions
diff --git a/views/controls/button/button.cc b/views/controls/button/button.cc index 504a2f5..460c424 100644 --- a/views/controls/button/button.cc +++ b/views/controls/button/button.cc @@ -64,6 +64,7 @@ Button::Button(ButtonListener* listener) : listener_(listener), tag_(-1), mouse_event_flags_(0) { + SetFocusable(true); } void Button::NotifyClick(const views::Event& event) { diff --git a/views/controls/button/native_button.cc b/views/controls/button/native_button.cc index 811fb56..76fb0ff 100644 --- a/views/controls/button/native_button.cc +++ b/views/controls/button/native_button.cc @@ -36,7 +36,6 @@ NativeButton::NativeButton(ButtonListener* listener) is_default_(false), ignore_minimum_size_(false) { InitBorder(); - SetFocusable(true); } NativeButton::NativeButton(ButtonListener* listener, const std::wstring& label) @@ -46,7 +45,6 @@ NativeButton::NativeButton(ButtonListener* listener, const std::wstring& label) ignore_minimum_size_(false) { SetLabel(label); // SetLabel takes care of label layout in RTL UI. InitBorder(); - SetFocusable(true); } NativeButton::~NativeButton() { diff --git a/views/controls/button/text_button.cc b/views/controls/button/text_button.cc index b5733c0..6bb3bec 100644 --- a/views/controls/button/text_button.cc +++ b/views/controls/button/text_button.cc @@ -330,6 +330,7 @@ void TextButton::SetEnabled(bool enabled) { } bool TextButton::OnMousePressed(const MouseEvent& e) { + RequestFocus(); return true; } |