diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-01 23:07:00 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-01 23:07:00 +0000 |
| commit | 3984b4b1edee2b14b0ebd41d31fc9fedfc7a0ef9 (patch) | |
| tree | 3ce2aba0fd25d8b37d61e58ae437107594f36d39 /views/controls/scroll_view.cc | |
| parent | 894b4a7c7323f0132f3a9611cfb71fa7eed223ad (diff) | |
| download | chromium_src-3984b4b1edee2b14b0ebd41d31fc9fedfc7a0ef9.zip chromium_src-3984b4b1edee2b14b0ebd41d31fc9fedfc7a0ef9.tar.gz chromium_src-3984b4b1edee2b14b0ebd41d31fc9fedfc7a0ef9.tar.bz2 | |
Lands http://codereview.chromium.org/449003/show for Thiago:
views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS).
Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues
pointed by lint.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/controls/scroll_view.cc')
| -rw-r--r-- | views/controls/scroll_view.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/views/controls/scroll_view.cc b/views/controls/scroll_view.cc index 84ce6c7..d484e74 100644 --- a/views/controls/scroll_view.cc +++ b/views/controls/scroll_view.cc @@ -31,7 +31,7 @@ class Viewport : public View { } private: - DISALLOW_EVIL_CONSTRUCTORS(Viewport); + DISALLOW_COPY_AND_ASSIGN(Viewport); }; @@ -338,7 +338,7 @@ void ScrollView::UpdateScrollBarPositions() { } } -// TODO(ACW). We should really use ScrollWindowEx as needed +// TODO(ACW): We should really use ScrollWindowEx as needed void ScrollView::ScrollToPosition(ScrollBar* source, int position) { if (!contents_) return; @@ -503,7 +503,7 @@ FixedRowHeightScrollHelper::FixedRowHeightScrollHelper(int top_margin, : VariableRowHeightScrollHelper(NULL), top_margin_(top_margin), row_height_(row_height) { - DCHECK(row_height > 0); + DCHECK_GT(row_height, 0); } VariableRowHeightScrollHelper::RowInfo |