summaryrefslogtreecommitdiffstats
path: root/views/controls/table
diff options
context:
space:
mode:
authorrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-25 19:03:40 +0000
committerrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-25 19:03:40 +0000
commit4701ef9aaa53c31cb0cdbddc716ae420ddd6bf10 (patch)
tree89e35cc3d00057c1a7c0e0a7876b69aa362c5b8a /views/controls/table
parentef617523bad57efc3fbc8a786a9e6c7070bbe388 (diff)
downloadchromium_src-4701ef9aaa53c31cb0cdbddc716ae420ddd6bf10.zip
chromium_src-4701ef9aaa53c31cb0cdbddc716ae420ddd6bf10.tar.gz
chromium_src-4701ef9aaa53c31cb0cdbddc716ae420ddd6bf10.tar.bz2
Mark TreeViewTests as FAILS_ rather than DISABLED_
TBR=jcivelli BUG=45015 Review URL: http://codereview.chromium.org/2171006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48168 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/controls/table')
-rw-r--r--views/controls/table/table_view_unittest.cc23
1 files changed, 12 insertions, 11 deletions
diff --git a/views/controls/table/table_view_unittest.cc b/views/controls/table/table_view_unittest.cc
index 99f0524..05a90952 100644
--- a/views/controls/table/table_view_unittest.cc
+++ b/views/controls/table/table_view_unittest.cc
@@ -234,8 +234,9 @@ class NullModelTableViewTest : public TableViewTest {
// Tests -----------------------------------------------------------------------
+// Several failing tests below: http://crbug.com/45015
// Tests various sorting permutations.
-TEST_F(TableViewTest, DISABLED_Sort) {
+TEST_F(TableViewTest, FAILS_Sort) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
@@ -262,7 +263,7 @@ TEST_F(TableViewTest, DISABLED_Sort) {
}
// Tests changing the model while sorted.
-TEST_F(TableViewTest, DISABLED_SortThenChange) {
+TEST_F(TableViewTest, FAILS_SortThenChange) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
@@ -276,7 +277,7 @@ TEST_F(TableViewTest, DISABLED_SortThenChange) {
}
// Tests adding to the model while sorted.
-TEST_F(TableViewTest, DISABLED_AddToSorted) {
+TEST_F(TableViewTest, FAILS_AddToSorted) {
// Sort by first column descending.
TableView::SortDescriptors sort;
sort.push_back(TableView::SortDescriptor(0, false));
@@ -297,7 +298,7 @@ TEST_F(TableViewTest, DISABLED_AddToSorted) {
}
// Tests selection on sort.
-TEST_F(TableViewTest, DISABLED_PersistSelectionOnSort) {
+TEST_F(TableViewTest, FAILS_PersistSelectionOnSort) {
// Select row 0.
table_->Select(0);
@@ -314,12 +315,12 @@ TEST_F(TableViewTest, DISABLED_PersistSelectionOnSort) {
}
// Tests selection iterator with sort.
-TEST_F(TableViewTest, PersistMultiSelectionOnSort) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnSort) {
SetUpMultiSelectTestState(true);
}
// Tests selection persists after a change when sorted with iterator.
-TEST_F(TableViewTest, PersistMultiSelectionOnChangeWithSort) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnChangeWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
@@ -330,7 +331,7 @@ TEST_F(TableViewTest, PersistMultiSelectionOnChangeWithSort) {
}
// Tests selection persists after a remove when sorted with iterator.
-TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemoveWithSort) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnRemoveWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
@@ -341,7 +342,7 @@ TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemoveWithSort) {
}
// Tests selection persists after a add when sorted with iterator.
-TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnAddWithSort) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnAddWithSort) {
SetUpMultiSelectTestState(true);
if (HasFatalFailure())
return;
@@ -352,7 +353,7 @@ TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnAddWithSort) {
}
// Tests selection persists after a change with iterator.
-TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnChange) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnChange) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
@@ -363,7 +364,7 @@ TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnChange) {
}
// Tests selection persists after a remove with iterator.
-TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemove) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnRemove) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;
@@ -374,7 +375,7 @@ TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnRemove) {
}
// Tests selection persists after a add with iterator.
-TEST_F(TableViewTest, DISABLED_PersistMultiSelectionOnAdd) {
+TEST_F(TableViewTest, FAILS_PersistMultiSelectionOnAdd) {
SetUpMultiSelectTestState(false);
if (HasFatalFailure())
return;