diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 19:14:54 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 19:14:54 +0000 |
commit | 7e38369f764596be0a38c0a1a7339c5ed43b67de (patch) | |
tree | 5d1c9f4bfc0e51f30cab13fbcfce40ea975a3782 /views/focus/focus_manager.cc | |
parent | 9fc286c694089736ee8e7b740302dc4dd080a6aa (diff) | |
download | chromium_src-7e38369f764596be0a38c0a1a7339c5ed43b67de.zip chromium_src-7e38369f764596be0a38c0a1a7339c5ed43b67de.tar.gz chromium_src-7e38369f764596be0a38c0a1a7339c5ed43b67de.tar.bz2 |
Changing the focus manager to not subclass HWNDs (but for the top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected.
Review URL: http://codereview.chromium.org/122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/focus/focus_manager.cc')
-rw-r--r-- | views/focus/focus_manager.cc | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/views/focus/focus_manager.cc b/views/focus/focus_manager.cc index 046d6ea..ab67301 100644 --- a/views/focus/focus_manager.cc +++ b/views/focus/focus_manager.cc @@ -71,10 +71,6 @@ static LRESULT CALLBACK FocusWindowCallback(HWND window, UINT message, // but that window may not have an associated FocusManager. if (focus_manager) { switch (message) { - case WM_SETFOCUS: - if (!focus_manager->OnSetFocus(window)) - return 0; - break; case WM_NCDESTROY: if (!focus_manager->OnNCDestroy(window)) return 0; @@ -189,21 +185,6 @@ FocusManager::~FocusManager() { #if defined(OS_WIN) // Message handlers. -bool FocusManager::OnSetFocus(HWND window) { - if (ignore_set_focus_msg_) - return true; - - // Focus the view associated with that window. - View* v = static_cast<View*>(GetProp(window, kViewKey)); - if (v && v->IsFocusable()) { - v->GetRootView()->FocusView(v); - } else { - SetFocusedView(NULL); - } - - return true; -} - bool FocusManager::OnNCDestroy(HWND window) { // Window is being destroyed, undo the subclassing. FocusManager::UninstallFocusSubclass(window); |