diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 04:28:07 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-14 04:28:07 +0000 |
| commit | ca13d804c304a61711352044022971ec39f9d4f8 (patch) | |
| tree | 81e2f1039a317a4ba5177ec98d18a545c0ff9c94 /views/focus/focus_manager.h | |
| parent | 921515182691bf105b404862bf80ae7dfc0e151e (diff) | |
| download | chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.zip chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.tar.gz chromium_src-ca13d804c304a61711352044022971ec39f9d4f8.tar.bz2 | |
Clean-up of the accelerator code.
The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing.
This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators.
Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused.
BUG=11538
TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus.
Also test that tab traversal still work as expected in the browser and in the option dialog.
Review URL: http://codereview.chromium.org/113307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/focus/focus_manager.h')
| -rw-r--r-- | views/focus/focus_manager.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/views/focus/focus_manager.h b/views/focus/focus_manager.h index 8c33036..98fc1e5 100644 --- a/views/focus/focus_manager.h +++ b/views/focus/focus_manager.h @@ -283,6 +283,11 @@ class FocusManager { AcceleratorTarget* GetTargetForAccelerator( const Accelerator& accelerator) const; + // Convenience method that returns true if the passed |key_event| should + // trigger tab traversal (if it is a TAB key press with or without SHIFT + // pressed). + static bool IsTabTraversalKeyEvent(const KeyEvent& key_event); + private: #if defined(OS_WIN) explicit FocusManager(HWND root, RootView* root_view); |