diff options
author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-02 16:34:16 +0000 |
---|---|---|
committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-02 16:34:16 +0000 |
commit | 695092fd7614c257866347f049e28ec327d7a3d3 (patch) | |
tree | dfe6ab2c6c0deff9bb6aa82e808c93df57b5c96d /views/focus/focus_manager.h | |
parent | 74d1397a6cd1d497fe27d6f0e27cd20d70e1ab85 (diff) | |
download | chromium_src-695092fd7614c257866347f049e28ec327d7a3d3.zip chromium_src-695092fd7614c257866347f049e28ec327d7a3d3.tar.gz chromium_src-695092fd7614c257866347f049e28ec327d7a3d3.tar.bz2 |
Add undeclared virtual destructors part 5
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3080013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/focus/focus_manager.h')
-rw-r--r-- | views/focus/focus_manager.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/views/focus/focus_manager.h b/views/focus/focus_manager.h index 73cfdc8..af6f414 100644 --- a/views/focus/focus_manager.h +++ b/views/focus/focus_manager.h @@ -93,6 +93,9 @@ class FocusTraversable { // It is used when walking up the view hierarchy tree to find which view // should be used as the starting view for finding the next/previous view. virtual View* GetFocusTraversableParentView() = 0; + + protected: + virtual ~FocusTraversable() {} }; // This interface should be implemented by classes that want to be notified when @@ -100,6 +103,9 @@ class FocusTraversable { class FocusChangeListener { public: virtual void FocusWillChange(View* focused_before, View* focused_now) = 0; + + protected: + virtual ~FocusChangeListener() {} }; // This interface should be implemented by classes that want to be notified when @@ -111,6 +117,9 @@ class WidgetFocusChangeListener { public: virtual void NativeFocusWillChange(gfx::NativeView focused_before, gfx::NativeView focused_now) = 0; + + protected: + virtual ~WidgetFocusChangeListener() {} }; class FocusManager { |