diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-10 21:07:04 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-10 21:07:04 +0000 |
| commit | f8dce00e633d5ffde45e008fb8f51d5a76942f6b (patch) | |
| tree | 7e7174b73f30eb981924f6bba5d581ed5ccaa41a /views/view.cc | |
| parent | 4db49098666ed9200af30bbd471c7faed40312af (diff) | |
| download | chromium_src-f8dce00e633d5ffde45e008fb8f51d5a76942f6b.zip chromium_src-f8dce00e633d5ffde45e008fb8f51d5a76942f6b.tar.gz chromium_src-f8dce00e633d5ffde45e008fb8f51d5a76942f6b.tar.bz2 | |
Landing oshima patch.
Disable NOTREACHED assertion for Linux. A view in WidgetGtk with TYPE_CHILD crashes
at this assertion. A bug http://crbug.com/21335 is filed to keep track of this.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/195056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25919 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/view.cc')
| -rw-r--r-- | views/view.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/views/view.cc b/views/view.cc index e47dbea..8664ad9 100644 --- a/views/view.cc +++ b/views/view.cc @@ -1022,7 +1022,13 @@ void View::RegisterPendingAccelerators() { // Some crash reports seem to show that we may get cases where we have no // focus manager (see bug #1291225). This should never be the case, just // making sure we don't crash. + + // TODO(jcampan): This fails for a view under WidgetGtk with TYPE_CHILD. + // (see http://crbug.com/21335) reenable NOTREACHED assertion and + // verify accelerators works as expected. +#if defined(OS_WIN) NOTREACHED(); +#endif return; } std::vector<Accelerator>::const_iterator iter; |