diff options
| author | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 15:16:10 +0000 |
|---|---|---|
| committer | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 15:16:10 +0000 |
| commit | 22b887aed04e9b9d13cb856abe1f57da08f348d7 (patch) | |
| tree | ae38d8e4beb0656970375a4f6b789fc973e61eb7 /views/view.h | |
| parent | 0da7636f1e91b05a407a310800d6fe79796931a4 (diff) | |
| download | chromium_src-22b887aed04e9b9d13cb856abe1f57da08f348d7.zip chromium_src-22b887aed04e9b9d13cb856abe1f57da08f348d7.tar.gz chromium_src-22b887aed04e9b9d13cb856abe1f57da08f348d7.tar.bz2 | |
Revert 42465 - Keyboard accessibility for the page and app menus.
Reverting because newly added Test*MenuKeyboardAccess tests fail on
some of the Windows buildbots, and possibly a XP Perf regression.
Works on Windows, and on Linux with toolkit_views.
The goal is to make Chrome behave more like a standard Windows
application, for users who rely on the keyboard and expect standard
keyboard accelerators to work.
Pressing F10, or pressing and releasing Alt, will set focus to the
Page menu, as if it was the first item in a menu bar.
Pressing enter, space, up arrow, or down arrow will open the focused menu.
Once a menu is opened, pressing left and right arrows will switch between
the two menus. Pressing escape will return focus to the title of the
previously open menu.
A new UI test attempts to select something from the menus using only the
keyboard. It works on Linux (with toolkit_views) and on Windows.
BUG=none
TEST=New keyboard accessibility ui test.
Review URL: http://codereview.chromium.org/660323
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/1257003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/view.h')
| -rw-r--r-- | views/view.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/views/view.h b/views/view.h index f2469f7..f83793b 100644 --- a/views/view.h +++ b/views/view.h @@ -609,12 +609,6 @@ class View : public AcceleratorTarget { // accessibility focus. virtual View* GetAccFocusedChildView() { return NULL; } - // Try to give accessibility focus to a given child view. Returns true on - // success. Returns false if this view isn't already focused, if it doesn't - // support accessibility focus for children, or if the given view isn't a - // valid child view that can receive accessibility focus. - virtual bool SetAccFocusedChildView(View* child_view) { return false; } - // Utility functions // Note that the utility coordinate conversions functions always operate on |