Some previous refactoring I did of the accelerator code had introduced regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox)

Review URL: http://codereview.chromium.org/119016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 9 deletions

diff --git a/views/view.h b/views/view.h
index 760192f..63fd56d 100644
--- a/views/view.h
+++ b/views/view.h
@@ -509,15 +509,6 @@ class View : public AcceleratorTarget {
     return false;
   }
 
-  // Called on a view (if it is has focus) before an Accelerator is processed.
-  // Views that want to override an accelerator should override this method to
-  // perform the required action and return true, to indicate that the
-  // accelerator should not be processed any further (in which case the key
-  // event is eaten).
-  virtual bool OverrideAccelerator(const Accelerator& accelerator) {
-    return false;
-  }
-
   // Returns whether this view currently has the focus.
   virtual bool HasFocus();