diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 18:48:00 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-30 18:48:00 +0000 |
commit | 82166b65c8cdd7cb855c2d018be8c6c815324af6 (patch) | |
tree | f96034ed91ce66d6a3ba2afa07cdd4be1e55b264 /views/views.gyp | |
parent | 7811b768ff61d58153a198a273cdb39581a77542 (diff) | |
download | chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.zip chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.tar.gz chromium_src-82166b65c8cdd7cb855c2d018be8c6c815324af6.tar.bz2 |
This CL removes the last (major) Windows specific part out of the focus manager.
It was previously landed and reverted because it broke the reliability tests.
http://codereview.chromium.org/125148
The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs.
The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure.
Files changed from the previous patch that need reviewing:
native_tab_contents_container_win.cc
tab_contents_view_win.h
tab_contents_view_win.cc
BUG=None
TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome.
Review URL: http://codereview.chromium.org/146093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/views.gyp')
-rw-r--r-- | views/views.gyp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/views/views.gyp b/views/views.gyp index b83ccae..8715403 100644 --- a/views/views.gyp +++ b/views/views.gyp @@ -42,9 +42,9 @@ 'type': '<(library)', 'msvs_guid': '6F9258E5-294F-47B2-919D-17FFE7A8B751', 'dependencies': [ - '../app/app.gyp:app_base', - '../app/app.gyp:app_strings', - '../app/app.gyp:app_resources', + '../app/app.gyp:app_base', + '../app/app.gyp:app_strings', + '../app/app.gyp:app_resources', '../skia/skia.gyp:skia', '../third_party/icu38/icu38.gyp:icui18n', '../third_party/icu38/icu38.gyp:icuuc', @@ -174,6 +174,8 @@ 'fill_layout.h', 'focus/external_focus_tracker.cc', 'focus/external_focus_tracker.h', + 'focus/focus_manager_gtk.cc', + 'focus/focus_manager_win.cc', 'focus/focus_manager.cc', 'focus/focus_manager.h', 'focus/focus_util_win.cc', |