summaryrefslogtreecommitdiffstats
path: root/views/views_delegate.h
diff options
context:
space:
mode:
authormdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-14 22:59:17 +0000
committermdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-14 22:59:17 +0000
commit9c587a0112d239f5d9fd6979e7b3be4a970068ad (patch)
tree77c2730342c13eb475bd74ef376378fe9731a672 /views/views_delegate.h
parentdbb9a148bc9c67581cb861d38d750127031157da (diff)
downloadchromium_src-9c587a0112d239f5d9fd6979e7b3be4a970068ad.zip
chromium_src-9c587a0112d239f5d9fd6979e7b3be4a970068ad.tar.gz
chromium_src-9c587a0112d239f5d9fd6979e7b3be4a970068ad.tar.bz2
Revert 92615 - Linux: make externally-stored passwords (e.g. GNOME Keyring) profile-specific.
This is accomplished by associating a randomly generated id with each profile, and storing the profile id with the passwords. The ids are chosen such that they are obviously not unique ids (there are more users than ids), yet within one machine they should be unique with high probability. Although profiles have names, it turns out that using these names as the identifiers is not preferable for two reasons. First, the names are actually the account email addresses, and not user-provided strings. The default profile, if not using sync, has the empty string for its name. This means that we still have to worry about migration in this case, and can't cleanly assume that existing passwords "belong" to the default profile, because we can't always tell which profile is the default. Second, the sync code seems to be rather non-robust and fails frequently when passwords change underneath it. Using the profile name would mean that the same account synced within different user data dirs would share passwords, which the sync code won't really like. (Of course, this is the current situation as well, with different user data dirs.) Speaking of migration: this change leaves the original, shared passwords alone, and they will be migrated (copied, really) into each profile the first time it is used. After a while, we can add code to delete these shared passwords so they don't persist forever without being visible in the UI. Eventually, we can remove the migration and deletion code. BUG=77022 Review URL: http://codereview.chromium.org/7212031 TBR=mdm@chromium.org Review URL: http://codereview.chromium.org/7373014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92618 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/views_delegate.h')
0 files changed, 0 insertions, 0 deletions