diff options
| author | yutak@chromium.org <yutak@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 23:52:20 +0000 |
|---|---|---|
| committer | yutak@chromium.org <yutak@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 23:52:20 +0000 |
| commit | 6d21eb72d7333889badc108afe21dd1bc52e1135 (patch) | |
| tree | a45694ee7b3b43fffc8db3dbe113c4ab52e246b9 /views/widget/widget_win.h | |
| parent | 8e0c43541d22b356b7eac90cfce4a4ebdd69c8f1 (diff) | |
| download | chromium_src-6d21eb72d7333889badc108afe21dd1bc52e1135.zip chromium_src-6d21eb72d7333889badc108afe21dd1bc52e1135.tar.gz chromium_src-6d21eb72d7333889badc108afe21dd1bc52e1135.tar.bz2 | |
Fix reversed focus traversal order issue.
This change fixes several problems in handling focus traversal and resolves TabbedPane's traversal order issue.
Reversed focus traversal is very tricky, and the original traversal code overlooked several things.
(1) A focusable view may have a FocusTraverasble.
(2) When we are going down, we have to check if the current view has a FocusTraversable.
(3) When we are going up from a FocusTraversable, the parent view may gain the next focus.
This change fixes these issues.
BUG=6871
TEST=See issue 6871.
Review URL: http://codereview.chromium.org/125062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18335 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/widget/widget_win.h')
| -rw-r--r-- | views/widget/widget_win.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/views/widget/widget_win.h b/views/widget/widget_win.h index 2a9562c..b8500c7 100644 --- a/views/widget/widget_win.h +++ b/views/widget/widget_win.h @@ -239,7 +239,7 @@ class WidgetWin : public Widget, virtual View* FindNextFocusableView(View* starting_view, bool reverse, Direction direction, - bool dont_loop, + bool check_starting_view, FocusTraversable** focus_traversable, View** focus_traversable_view); virtual FocusTraversable* GetFocusTraversableParent(); |