diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-29 00:33:35 +0000 |
| commit | bc1407f95bae3d7472ee0c85ef83ee10610b3f1f (patch) | |
| tree | eeb1e01423fefc13afe5738d809df200b5e50623 /views/widget | |
| parent | 62525634a6f5727216828f8e05a4f563be90dfeb (diff) | |
| download | chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.zip chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.gz chromium_src-bc1407f95bae3d7472ee0c85ef83ee10610b3f1f.tar.bz2 | |
Relanding keyboard code refactoring:
http://codereview.chromium.org/248010/show
Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_.
Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly.
BUG=None
TEST=Make sure short-cuts works as expected, especially in the omnibox.
Review URL: http://codereview.chromium.org/251020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/widget')
| -rw-r--r-- | views/widget/root_view.cc | 4 | ||||
| -rw-r--r-- | views/widget/widget_win.cc | 6 |
2 files changed, 6 insertions, 4 deletions
diff --git a/views/widget/root_view.cc b/views/widget/root_view.cc index 8baca07..09c1909 100644 --- a/views/widget/root_view.cc +++ b/views/widget/root_view.cc @@ -782,8 +782,8 @@ bool RootView::ProcessKeyEvent(const KeyEvent& event) { View* v = GetFocusedView(); // Special case to handle right-click context menus triggered by the // keyboard. - if (v && v->IsEnabled() && ((event.GetCharacter() == base::VKEY_APPS) || - (event.GetCharacter() == base::VKEY_F10 && event.IsShiftDown()))) { + if (v && v->IsEnabled() && ((event.GetKeyCode() == base::VKEY_APPS) || + (event.GetKeyCode() == base::VKEY_F10 && event.IsShiftDown()))) { gfx::Point screen_loc = v->GetKeyboardContextMenuLocation(); v->ShowContextMenu(screen_loc.x(), screen_loc.y(), false); return true; diff --git a/views/widget/widget_win.cc b/views/widget/widget_win.cc index d975ef9..3017e05 100644 --- a/views/widget/widget_win.cc +++ b/views/widget/widget_win.cc @@ -571,12 +571,14 @@ void WidgetWin::OnInitMenuPopup(HMENU menu, } void WidgetWin::OnKeyDown(TCHAR c, UINT rep_cnt, UINT flags) { - KeyEvent event(Event::ET_KEY_PRESSED, c, rep_cnt, flags); + KeyEvent event(Event::ET_KEY_PRESSED, + win_util::WinToKeyboardCode(c), rep_cnt, flags); SetMsgHandled(root_view_->ProcessKeyEvent(event)); } void WidgetWin::OnKeyUp(TCHAR c, UINT rep_cnt, UINT flags) { - KeyEvent event(Event::ET_KEY_RELEASED, c, rep_cnt, flags); + KeyEvent event(Event::ET_KEY_RELEASED, + win_util::WinToKeyboardCode(c), rep_cnt, flags); SetMsgHandled(root_view_->ProcessKeyEvent(event)); } |