diff options
author | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-15 21:57:03 +0000 |
---|---|---|
committer | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-15 21:57:03 +0000 |
commit | f54af0416c4462df0cdb8b05f807262acb9f1016 (patch) | |
tree | 1d6d06fa22e72898ffed9a6234f14a66b18b637c /views/window/window_gtk.h | |
parent | 9e2d898dd3fdb84ed742947fbcb88400904a4a5b (diff) | |
download | chromium_src-f54af0416c4462df0cdb8b05f807262acb9f1016.zip chromium_src-f54af0416c4462df0cdb8b05f807262acb9f1016.tar.gz chromium_src-f54af0416c4462df0cdb8b05f807262acb9f1016.tar.bz2 |
Make DevTools open docked by default for chrome os.
- Change prefs::kDevToolsOpenDocked default to "true" for chrome os;
- Fix a problem on chrome os that DevTools occupies the whole client area.
This is because BrowserView::Show is called before gtk size allocated
event and thus divider offset is calculated wrongly to 0. The fix is
to move the "restore split offset" logic to UpdateDevToolsForContents
before we do contents_split_ layout for show up DevTools;
- Fix a problem that DevTools becomes invisible after undock then dock
for linux toolkit_view/chromeos build. This is because
browser/views/tab_contents/TabContentsViewGtk does not show/hide its
contained TabContents like TabContentsViewWin. As mentioned in
BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up
gtk show/hide signal and notify the contained TabContents about the
visibility change. After the fix, remove the manual ShowContents for
DevTools in BrowserWindowGtk::UpdateDevToolsForContents.
<http://crosbug.com/333>
BUG=333
TEST=Verify that DevTools show up as docked by default.
Review URL: http://codereview.chromium.org/880003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views/window/window_gtk.h')
-rw-r--r-- | views/window/window_gtk.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/views/window/window_gtk.h b/views/window/window_gtk.h index a9457af..865ac81 100644 --- a/views/window/window_gtk.h +++ b/views/window/window_gtk.h @@ -79,7 +79,7 @@ class WindowGtk : public WidgetGtk, public Window { // Initializes the window to the passed in bounds. void Init(GtkWindow* parent, const gfx::Rect& bounds); - virtual void OnDestroy(); + virtual void OnDestroy(GtkWidget* widget); private: static gboolean CallConfigureEvent(GtkWidget* widget, |