summaryrefslogtreecommitdiffstats
path: root/views
diff options
context:
space:
mode:
authormaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-13 17:52:48 +0000
committermaruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-13 17:52:48 +0000
commit00ffe5dd99527a0cb1035af6749417f5fb1c134e (patch)
tree4354d5b35be202204d9392417862b423ba374ce0 /views
parent65f73a3a996bdbaa167e38704df092aa39b53d3a (diff)
downloadchromium_src-00ffe5dd99527a0cb1035af6749417f5fb1c134e.zip
chromium_src-00ffe5dd99527a0cb1035af6749417f5fb1c134e.tar.gz
chromium_src-00ffe5dd99527a0cb1035af6749417f5fb1c134e.tar.bz2
Revert 15965. I wasn't supposed to check that in since it still doesn't compile on linux and mac!
TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views')
-rw-r--r--views/controls/button/button_dropdown.cc3
-rw-r--r--views/controls/button/menu_button.cc5
-rw-r--r--views/controls/button/native_button_win.cc2
-rw-r--r--views/controls/hwnd_view.cc7
-rw-r--r--views/controls/menu/view_menu_delegate.h8
-rw-r--r--views/controls/message_box_view.cc4
-rw-r--r--views/controls/native_control.cc3
-rw-r--r--views/controls/native_control.h6
-rw-r--r--views/controls/scrollbar/bitmap_scroll_bar.cc17
-rw-r--r--views/controls/table/group_table_view.cc15
-rw-r--r--views/controls/table/group_table_view.h2
-rw-r--r--views/controls/table/table_view.cc27
-rw-r--r--views/controls/table/table_view.h3
-rw-r--r--views/controls/text_field.cc1
-rw-r--r--views/controls/tree/tree_view.cc8
-rw-r--r--views/controls/tree/tree_view.h5
-rw-r--r--views/grid_layout_unittest.cc22
-rw-r--r--views/view.h10
-rw-r--r--views/widget/root_view_drop_target.h4
-rw-r--r--views/widget/tooltip_manager.cc1
-rw-r--r--views/widget/widget_win.h8
-rw-r--r--views/window/custom_frame_view.cc11
-rw-r--r--views/window/window_win.h2
23 files changed, 75 insertions, 99 deletions
diff --git a/views/controls/button/button_dropdown.cc b/views/controls/button/button_dropdown.cc
index 157caf0..270894b 100644
--- a/views/controls/button/button_dropdown.cc
+++ b/views/controls/button/button_dropdown.cc
@@ -5,7 +5,6 @@
#include "views/controls/button/button_dropdown.h"
#include "app/l10n_util.h"
-#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "grit/generated_resources.h"
#include "views/controls/menu/view_menu_delegate.h"
@@ -27,7 +26,7 @@ ButtonDropDown::ButtonDropDown(ButtonListener* listener,
: ImageButton(listener),
menu_delegate_(menu_delegate),
y_position_on_lbuttondown_(0),
- ALLOW_THIS_IN_INITIALIZER_LIST(show_menu_factory_(this)) {
+ show_menu_factory_(this) {
}
ButtonDropDown::~ButtonDropDown() {
diff --git a/views/controls/button/menu_button.cc b/views/controls/button/menu_button.cc
index 6dbf4ae..993cd9b 100644
--- a/views/controls/button/menu_button.cc
+++ b/views/controls/button/menu_button.cc
@@ -110,7 +110,7 @@ int MenuButton::GetMaximumScreenXCoordinate() {
}
HWND hwnd = widget->GetNativeView();
- RECT t;
+ CRect t;
::GetWindowRect(hwnd, &t);
gfx::Rect r(t);
@@ -154,7 +154,8 @@ bool MenuButton::Activate() {
GetRootView()->SetMouseHandler(NULL);
menu_visible_ = true;
- menu_delegate_->RunMenu(this, menu_position, GetWidget()->GetNativeView());
+ menu_delegate_->RunMenu(this, menu_position.ToPOINT(),
+ GetWidget()->GetNativeView());
menu_visible_ = false;
menu_closed_time_ = Time::Now();
diff --git a/views/controls/button/native_button_win.cc b/views/controls/button/native_button_win.cc
index 5dd70d3..6748241 100644
--- a/views/controls/button/native_button_win.cc
+++ b/views/controls/button/native_button_win.cc
@@ -4,8 +4,6 @@
#include "views/controls/button/native_button_win.h"
-#include <commctrl.h>
-
#include "base/logging.h"
#include "views/controls/button/checkbox.h"
#include "views/controls/button/native_button.h"
diff --git a/views/controls/hwnd_view.cc b/views/controls/hwnd_view.cc
index fdf4042..677e60a 100644
--- a/views/controls/hwnd_view.cc
+++ b/views/controls/hwnd_view.cc
@@ -110,10 +110,9 @@ void HWNDView::ShowWidget(int x, int y, int w, int h) {
if (fast_resize()) {
// In a fast resize, we move the window and clip it with SetWindowRgn.
- RECT win_rect;
- GetWindowRect(native_view(), &win_rect);
- gfx::Rect rect(win_rect);
- ::SetWindowPos(native_view(), 0, x, y, rect.width(), rect.height(),
+ CRect rect;
+ GetWindowRect(native_view(), &rect);
+ ::SetWindowPos(native_view(), 0, x, y, rect.Width(), rect.Height(),
swp_flags);
HRGN clip_region = CreateRectRgn(0, 0, w, h);
diff --git a/views/controls/menu/view_menu_delegate.h b/views/controls/menu/view_menu_delegate.h
index 3d6887b..bb72ed3 100644
--- a/views/controls/menu/view_menu_delegate.h
+++ b/views/controls/menu/view_menu_delegate.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -7,10 +7,6 @@
#include "base/gfx/native_widget_types.h"
-namespace gfx {
-class Point;
-}
-
namespace views {
class View;
@@ -29,7 +25,7 @@ class ViewMenuDelegate {
// Create and show a menu at the specified position. Source is the view the
// ViewMenuDelegate was set on.
virtual void RunMenu(View* source,
- const gfx::Point& pt,
+ const CPoint& pt,
gfx::NativeView hwnd) = 0;
};
diff --git a/views/controls/message_box_view.cc b/views/controls/message_box_view.cc
index 2ac20af..e0cf055 100644
--- a/views/controls/message_box_view.cc
+++ b/views/controls/message_box_view.cc
@@ -30,7 +30,7 @@ MessageBoxView::MessageBoxView(int dialog_flags,
icon_(NULL),
checkbox_(NULL),
message_width_(message_width),
- ALLOW_THIS_IN_INITIALIZER_LIST(focus_grabber_factory_(this)) {
+ focus_grabber_factory_(this) {
Init(dialog_flags, default_prompt);
}
@@ -42,7 +42,7 @@ MessageBoxView::MessageBoxView(int dialog_flags,
icon_(NULL),
checkbox_(NULL),
message_width_(kDefaultMessageWidth),
- ALLOW_THIS_IN_INITIALIZER_LIST(focus_grabber_factory_(this)) {
+ focus_grabber_factory_(this) {
Init(dialog_flags, default_prompt);
}
diff --git a/views/controls/native_control.cc b/views/controls/native_control.cc
index 6b0b7df..ce37193 100644
--- a/views/controls/native_control.cc
+++ b/views/controls/native_control.cc
@@ -8,7 +8,6 @@
#include <atlapp.h>
#include <atlcrack.h>
#include <atlframe.h>
-#include <atlmisc.h>
#include "app/l10n_util_win.h"
#include "base/logging.h"
@@ -128,7 +127,7 @@ class NativeControlContainer : public CWindowImpl<NativeControlContainer,
TRACK_HWND_DESTRUCTION(m_hWnd);
}
- void OnContextMenu(HWND window, const WTL::CPoint& location) {
+ void OnContextMenu(HWND window, const CPoint& location) {
if (parent_)
parent_->OnContextMenu(location);
}
diff --git a/views/controls/native_control.h b/views/controls/native_control.h
index 39022a2..0573168 100644
--- a/views/controls/native_control.h
+++ b/views/controls/native_control.h
@@ -9,10 +9,6 @@
#include "views/view.h"
-namespace WTL {
-class CPoint;
-}
-
namespace views {
class HWNDView;
@@ -57,7 +53,7 @@ class NativeControl : public View {
virtual LRESULT OnCommand(UINT code, int id, HWND source) { return 0; }
// Invoked when the appropriate gesture for a context menu is issued.
- virtual void OnContextMenu(const WTL::CPoint& location);
+ virtual void OnContextMenu(const CPoint& location);
// Overridden so to set the native focus to the native control.
virtual void Focus();
diff --git a/views/controls/scrollbar/bitmap_scroll_bar.cc b/views/controls/scrollbar/bitmap_scroll_bar.cc
index 18096fb..e484517 100644
--- a/views/controls/scrollbar/bitmap_scroll_bar.cc
+++ b/views/controls/scrollbar/bitmap_scroll_bar.cc
@@ -6,7 +6,6 @@
#include "app/gfx/chrome_canvas.h"
#include "app/l10n_util.h"
-#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "grit/generated_resources.h"
#include "third_party/skia/include/core/SkBitmap.h"
@@ -38,9 +37,8 @@ class AutorepeatButton : public ImageButton {
public:
AutorepeatButton(ButtonListener* listener)
: ImageButton(listener),
- ALLOW_THIS_IN_INITIALIZER_LIST(repeater_(
- NewCallback<AutorepeatButton>(this,
- &AutorepeatButton::NotifyClick))) {
+ repeater_(NewCallback<AutorepeatButton>(this,
+ &AutorepeatButton::NotifyClick)) {
}
virtual ~AutorepeatButton() {}
@@ -257,14 +255,13 @@ class BitmapScrollBarThumb : public View {
BitmapScrollBar::BitmapScrollBar(bool horizontal, bool show_scroll_buttons)
: contents_size_(0),
contents_scroll_offset_(0),
- ALLOW_THIS_IN_INITIALIZER_LIST(prev_button_(new AutorepeatButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(next_button_(new AutorepeatButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(thumb_(new BitmapScrollBarThumb(this))),
+ prev_button_(new AutorepeatButton(this)),
+ next_button_(new AutorepeatButton(this)),
+ thumb_(new BitmapScrollBarThumb(this)),
thumb_track_state_(CustomButton::BS_NORMAL),
last_scroll_amount_(SCROLL_NONE),
- ALLOW_THIS_IN_INITIALIZER_LIST(repeater_(
- NewCallback<BitmapScrollBar>(this,
- &BitmapScrollBar::TrackClicked))),
+ repeater_(NewCallback<BitmapScrollBar>(this,
+ &BitmapScrollBar::TrackClicked)),
context_menu_mouse_position_(0),
show_scroll_buttons_(show_scroll_buttons),
ScrollBar(horizontal) {
diff --git a/views/controls/table/group_table_view.cc b/views/controls/table/group_table_view.cc
index b5d5698..5e6a155 100644
--- a/views/controls/table/group_table_view.cc
+++ b/views/controls/table/group_table_view.cc
@@ -5,7 +5,6 @@
#include "views/controls/table/group_table_view.h"
#include "app/gfx/chrome_canvas.h"
-#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "base/task.h"
@@ -25,7 +24,7 @@ GroupTableView::GroupTableView(GroupTableModel* model,
: TableView(model, columns, table_type, false, resizable_columns,
autosize_columns),
model_(model),
- ALLOW_THIS_IN_INITIALIZER_LIST(sync_selection_factory_(this)) {
+ sync_selection_factory_(this) {
}
GroupTableView::~GroupTableView() {
@@ -166,22 +165,22 @@ void GroupTableView::OnSelectedStateChanged() {
// Draws the line separator betweens the groups.
void GroupTableView::PostPaint(int model_row, int column, bool selected,
- const gfx::Rect& bounds, HDC hdc) {
+ const CRect& bounds, HDC hdc) {
GroupRange group_range;
model_->GetGroupRangeForItem(model_row, &group_range);
// We always paint a vertical line at the end of the last cell.
HPEN hPen = CreatePen(PS_SOLID, kSeparatorLineThickness, kSeparatorLineColor);
HPEN hPenOld = (HPEN) SelectObject(hdc, hPen);
- int x = static_cast<int>(bounds.right() - kSeparatorLineThickness);
- MoveToEx(hdc, x, bounds.y(), NULL);
- LineTo(hdc, x, bounds.bottom());
+ int x = static_cast<int>(bounds.right - kSeparatorLineThickness);
+ MoveToEx(hdc, x, bounds.top, NULL);
+ LineTo(hdc, x, bounds.bottom);
// We paint a separator line after the last item of a group.
if (model_row == (group_range.start + group_range.length - 1)) {
- int y = static_cast<int>(bounds.bottom() - kSeparatorLineThickness);
+ int y = static_cast<int>(bounds.bottom - kSeparatorLineThickness);
MoveToEx(hdc, 0, y, NULL);
- LineTo(hdc, bounds.width(), y);
+ LineTo(hdc, bounds.Width(), y);
}
SelectObject(hdc, hPenOld);
DeleteObject(hPen);
diff --git a/views/controls/table/group_table_view.h b/views/controls/table/group_table_view.h
index e581d5d..d128759 100644
--- a/views/controls/table/group_table_view.h
+++ b/views/controls/table/group_table_view.h
@@ -48,7 +48,7 @@ class GroupTableView : public TableView {
// Extra-painting required to draw the separator line between groups.
virtual bool ImplementPostPaint() { return true; }
virtual void PostPaint(int model_row, int column, bool selected,
- const gfx::Rect& bounds, HDC device_context);
+ const CRect& bounds, HDC device_context);
// In order to make keyboard navigation possible (using the Up and Down
// keys), we must take action when an arrow key is pressed. The reason we
diff --git a/views/controls/table/table_view.cc b/views/controls/table/table_view.cc
index 0f7d6b9..5ab86d3 100644
--- a/views/controls/table/table_view.cc
+++ b/views/controls/table/table_view.cc
@@ -4,12 +4,8 @@
#include "views/controls/table/table_view.h"
-#include <windowsx.h>
-#include <atlbase.h>
-#include <atlapp.h>
-#include <atlmisc.h>
-
#include <algorithm>
+#include <windowsx.h>
#include "app/gfx/chrome_canvas.h"
#include "app/gfx/favicon_size.h"
@@ -99,7 +95,7 @@ TableView::TableView(TableModel* model,
list_view_(NULL),
header_original_handler_(NULL),
original_handler_(NULL),
- ALLOW_THIS_IN_INITIALIZER_LIST(table_view_wrapper_(this)),
+ table_view_wrapper_(this),
custom_cell_font_(NULL),
content_offset_(0) {
for (std::vector<TableColumn>::const_iterator i = columns.begin();
@@ -578,10 +574,10 @@ LRESULT CALLBACK TableView::TableWndProc(HWND window,
// the position supplied in the l_param.
if (table_view->UILayoutIsRightToLeft() &&
(GET_X_LPARAM(l_param) != -1 || GET_Y_LPARAM(l_param) != -1)) {
- WTL::CPoint screen_point;
+ CPoint screen_point;
GetCursorPos(&screen_point);
- WTL::CPoint table_point = screen_point;
- WTL::CRect client_rect;
+ CPoint table_point = screen_point;
+ CRect client_rect;
if (ScreenToClient(window, &table_point) &&
GetClientRect(window, &client_rect) &&
client_rect.PtInRect(table_point)) {
@@ -1235,11 +1231,11 @@ LRESULT TableView::OnCustomDraw(NMLVCUSTOMDRAW* draw_info) {
SkBitmap image = model_->GetIcon(model_index);
if (!image.isNull()) {
// Get the rect that holds the icon.
- WTL::CRect icon_rect, client_rect;
+ CRect icon_rect, client_rect;
if (ListView_GetItemRect(list_view_, view_index, &icon_rect,
LVIR_ICON) &&
GetClientRect(list_view_, &client_rect)) {
- WTL::CRect intersection;
+ CRect intersection;
// Client rect includes the header but we need to make sure we don't
// paint into it.
client_rect.top += content_offset_;
@@ -1291,11 +1287,10 @@ LRESULT TableView::OnCustomDraw(NMLVCUSTOMDRAW* draw_info) {
}
}
if (ImplementPostPaint()) {
- WTL::CRect cell_rect;
+ CRect cell_rect;
if (ListView_GetItemRect(list_view_, view_index, &cell_rect,
LVIR_BOUNDS)) {
- PostPaint(model_index, 0, false, gfx::Rect(cell_rect),
- draw_info->nmcd.hdc);
+ PostPaint(model_index, 0, false, cell_rect, draw_info->nmcd.hdc);
r = CDRF_SKIPDEFAULT;
}
}
@@ -1318,7 +1313,7 @@ void TableView::ResetColumnSizes() {
// See comment in TableColumn for what this does.
int width = this->width();
- WTL::CRect native_bounds;
+ CRect native_bounds;
if (GetClientRect(GetNativeControlHWND(), &native_bounds) &&
native_bounds.Width() > 0) {
// Prefer the bounds of the window over our bounds, which may be different.
@@ -1529,7 +1524,7 @@ void TableView::UpdateContentOffset() {
POINT origin = {0, 0};
MapWindowPoints(header, list_view_, &origin, 1);
- WTL::CRect header_bounds;
+ CRect header_bounds;
GetWindowRect(header, &header_bounds);
content_offset_ = origin.y + header_bounds.Height();
diff --git a/views/controls/table/table_view.h b/views/controls/table/table_view.h
index da228fc..2db5234 100644
--- a/views/controls/table/table_view.h
+++ b/views/controls/table/table_view.h
@@ -9,7 +9,6 @@
#if defined(OS_WIN)
#include <windows.h>
-typedef struct tagNMLVCUSTOMDRAW NMLVCUSTOMDRAW;
#endif // defined(OS_WIN)
#include <map>
@@ -471,7 +470,7 @@ class TableView : public NativeControl,
virtual bool ImplementPostPaint() { return false; }
// Subclasses can implement in this method extra-painting for cells.
virtual void PostPaint(int model_row, int column, bool selected,
- const gfx::Rect& bounds, HDC device_context) { }
+ const CRect& bounds, HDC device_context) { }
virtual void PostPaint() {}
virtual HWND CreateNativeControl(HWND parent_container);
diff --git a/views/controls/text_field.cc b/views/controls/text_field.cc
index 6fd9c3e..0395af3 100644
--- a/views/controls/text_field.cc
+++ b/views/controls/text_field.cc
@@ -8,7 +8,6 @@
#include <atlapp.h>
#include <atlcrack.h>
#include <atlctrls.h>
-#include <atlmisc.h>
#include <tom.h> // For ITextDocument, a COM interface to CRichEditCtrl
#include <vsstyle.h>
diff --git a/views/controls/tree/tree_view.cc b/views/controls/tree/tree_view.cc
index d6f6627..894aa6e 100644
--- a/views/controls/tree/tree_view.cc
+++ b/views/controls/tree/tree_view.cc
@@ -4,9 +4,7 @@
#include "views/controls/tree/tree_view.h"
-#include <atlbase.h>
-#include <atlapp.h>
-#include <atlmisc.h>
+#include <shellapi.h>
#include "app/gfx/chrome_canvas.h"
#include "app/gfx/icon_util.h"
@@ -32,7 +30,7 @@ TreeView::TreeView()
process_enter_(false),
show_context_menu_only_when_node_selected_(true),
select_on_right_mouse_down_(true),
- ALLOW_THIS_IN_INITIALIZER_LIST(wrapper_(this)),
+ wrapper_(this),
original_handler_(NULL),
drag_enabled_(false),
has_custom_icons_(false),
@@ -483,7 +481,7 @@ bool TreeView::OnKeyDown(int virtual_key_code) {
return false;
}
-void TreeView::OnContextMenu(const WTL::CPoint& location) {
+void TreeView::OnContextMenu(const CPoint& location) {
if (!GetContextMenuController())
return;
diff --git a/views/controls/tree/tree_view.h b/views/controls/tree/tree_view.h
index fe470c0..1ded058 100644
--- a/views/controls/tree/tree_view.h
+++ b/views/controls/tree/tree_view.h
@@ -5,9 +5,6 @@
#ifndef VIEWS_CONTROLS_TREE_TREE_VIEW_H_
#define VIEWS_CONTROLS_TREE_TREE_VIEW_H_
-#include <windows.h>
-#include <commctrl.h>
-
#include <map>
#include "base/basictypes.h"
@@ -162,7 +159,7 @@ class TreeView : public NativeControl, TreeModelObserver {
virtual bool NotifyOnKeyDown() const { return true; }
virtual bool OnKeyDown(int virtual_key_code);
- virtual void OnContextMenu(const WTL::CPoint& location);
+ virtual void OnContextMenu(const CPoint& location);
// Returns the TreeModelNode for |tree_item|.
TreeModelNode* GetNodeForTreeItem(HTREEITEM tree_item);
diff --git a/views/grid_layout_unittest.cc b/views/grid_layout_unittest.cc
index cd38fc8..57bfa83 100644
--- a/views/grid_layout_unittest.cc
+++ b/views/grid_layout_unittest.cc
@@ -53,7 +53,7 @@ class GridLayoutTest : public testing::Test {
}
gfx::Size pref;
- gfx::Rect bounds;
+ CRect bounds;
View host;
GridLayout* layout;
};
@@ -78,7 +78,7 @@ class GridLayoutAlignmentTest : public testing::Test {
}
}
- void TestAlignment(GridLayout::Alignment alignment, gfx::Rect* bounds) {
+ void TestAlignment(GridLayout::Alignment alignment, CRect* bounds) {
ColumnSet* c1 = layout->AddColumnSet(0);
c1->AddColumn(alignment, alignment, 1, GridLayout::USE_PREF, 0, 0);
layout->StartRow(1, 0);
@@ -87,7 +87,7 @@ class GridLayoutAlignmentTest : public testing::Test {
EXPECT_TRUE(gfx::Size(10, 20) == pref);
host.SetBounds(0, 0, 100, 100);
layout->Layout(&host);
- *bounds = v1.bounds();
+ *bounds = v1.bounds().ToRECT();
RemoveAll();
}
@@ -97,27 +97,27 @@ class GridLayoutAlignmentTest : public testing::Test {
};
TEST_F(GridLayoutAlignmentTest, Fill) {
- gfx::Rect bounds;
+ CRect bounds;
TestAlignment(GridLayout::FILL, &bounds);
- EXPECT_TRUE(gfx::Rect(0, 0, 100, 100) == bounds);
+ EXPECT_TRUE(CRect(0, 0, 100, 100) == bounds);
}
TEST_F(GridLayoutAlignmentTest, Leading) {
- gfx::Rect bounds;
+ CRect bounds;
TestAlignment(GridLayout::LEADING, &bounds);
- EXPECT_TRUE(gfx::Rect(0, 0, 10, 20) == bounds);
+ EXPECT_TRUE(CRect(0, 0, 10, 20) == bounds);
}
TEST_F(GridLayoutAlignmentTest, Center) {
- gfx::Rect bounds;
+ CRect bounds;
TestAlignment(GridLayout::CENTER, &bounds);
- EXPECT_TRUE(gfx::Rect(45, 40, 55, 60) == bounds);
+ EXPECT_TRUE(CRect(45, 40, 55, 60) == bounds);
}
TEST_F(GridLayoutAlignmentTest, Trailing) {
- gfx::Rect bounds;
+ CRect bounds;
TestAlignment(GridLayout::TRAILING, &bounds);
- EXPECT_TRUE(gfx::Rect(90, 80, 100, 100) == bounds);
+ EXPECT_TRUE(CRect(90, 80, 100, 100) == bounds);
}
TEST_F(GridLayoutTest, TwoColumns) {
diff --git a/views/view.h b/views/view.h
index e5360213..ed4d4a0 100644
--- a/views/view.h
+++ b/views/view.h
@@ -7,6 +7,12 @@
#include "build/build_config.h"
+#if defined(OS_WIN)
+#include <atlbase.h>
+#include <atlapp.h>
+#include <atlmisc.h>
+#endif // defined(OS_WIN)
+
#include <algorithm>
#include <map>
#include <string>
@@ -19,10 +25,6 @@
#include "views/background.h"
#include "views/border.h"
-#if defined(OS_WIN)
-struct IDataObject;
-#endif // defined(OS_WIN)
-
namespace gfx {
class Insets;
class Path;
diff --git a/views/widget/root_view_drop_target.h b/views/widget/root_view_drop_target.h
index 32cb14b..a3c3afd 100644
--- a/views/widget/root_view_drop_target.h
+++ b/views/widget/root_view_drop_target.h
@@ -5,6 +5,10 @@
#ifndef VIEWS_WIDGET_ROOT_VIEW_DROP_TARGET_H_
#define VIEWS_WIDGET_ROOT_VIEW_DROP_TARGET_H_
+#include <atlbase.h>
+#include <atlapp.h>
+#include <atlmisc.h>
+
#include "app/os_exchange_data.h"
#include "base/base_drop_target.h"
diff --git a/views/widget/tooltip_manager.cc b/views/widget/tooltip_manager.cc
index c082040..59612e4 100644
--- a/views/widget/tooltip_manager.cc
+++ b/views/widget/tooltip_manager.cc
@@ -4,7 +4,6 @@
#include "views/widget/tooltip_manager.h"
-#include <windowsx.h>
#include <limits>
#include "app/gfx/text_elider.h"
diff --git a/views/widget/widget_win.h b/views/widget/widget_win.h
index b39362f..d948e66 100644
--- a/views/widget/widget_win.h
+++ b/views/widget/widget_win.h
@@ -6,9 +6,7 @@
#define VIEWS_WIDGET_WIDGET_WIN_H_
#include <atlbase.h>
-#include <atlapp.h>
#include <atlcrack.h>
-#include <atlmisc.h>
#include "base/message_loop.h"
#include "base/system_monitor.h"
@@ -38,7 +36,7 @@ RootView* GetRootViewForHWND(HWND hwnd);
// uMsg - kReflectedMessage
// wParam - Should be 0
// lParam - Pointer to MSG struct containing the original message.
-const int kReflectedMessage = WM_APP + 3;
+static const int kReflectedMessage = WM_APP + 3;
// These two messages aren't defined in winuser.h, but they are sent to windows
// with captions. They appear to paint the window caption and frame.
@@ -48,8 +46,8 @@ const int kReflectedMessage = WM_APP + 3;
// window and paint the standard caption/title over the top of the custom one.
// So we need to handle these messages in CustomFrameWindow to prevent this
// from happening.
-const int WM_NCUAHDRAWCAPTION = 0xAE;
-const int WM_NCUAHDRAWFRAME = 0xAF;
+static const int WM_NCUAHDRAWCAPTION = 0xAE;
+static const int WM_NCUAHDRAWFRAME = 0xAF;
///////////////////////////////////////////////////////////////////////////////
//
diff --git a/views/window/custom_frame_view.cc b/views/window/custom_frame_view.cc
index 19ce2fb..66e2ccd 100644
--- a/views/window/custom_frame_view.cc
+++ b/views/window/custom_frame_view.cc
@@ -74,12 +74,11 @@ const int kCaptionTopSpacing = 1;
CustomFrameView::CustomFrameView(Window* frame)
: NonClientFrameView(),
- ALLOW_THIS_IN_INITIALIZER_LIST(close_button_(new ImageButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(restore_button_(new ImageButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(maximize_button_(new ImageButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(minimize_button_(new ImageButton(this))),
- ALLOW_THIS_IN_INITIALIZER_LIST(
- system_menu_button_(new ImageButton(this))),
+ close_button_(new ImageButton(this)),
+ restore_button_(new ImageButton(this)),
+ maximize_button_(new ImageButton(this)),
+ minimize_button_(new ImageButton(this)),
+ system_menu_button_(new ImageButton(this)),
should_show_minmax_buttons_(false),
frame_(frame) {
InitClass();
diff --git a/views/window/window_win.h b/views/window/window_win.h
index 5a90835..76d5196 100644
--- a/views/window/window_win.h
+++ b/views/window/window_win.h
@@ -6,6 +6,8 @@
#define VIEWS_WINDOW_WINDOW_WIN_H_
#include "views/widget/widget_win.h"
+#include "views/window/client_view.h"
+#include "views/window/non_client_view.h"
#include "views/window/window.h"
namespace gfx {