diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
| commit | 515f2492fbc0a023eb089e91e349106da325de5e (patch) | |
| tree | d606fd354fe6c4695fe2f635e62774fe582e8232 /views | |
| parent | a834a1abc0a318a563d9a0eb3adec0df2947a982 (diff) | |
| download | chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.zip chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.gz chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.bz2 | |
Clang: enable -Wbool-conversions and -Wunused-variables on Linux.
-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace
that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah)
for good measure (even though that doesn't generate warnings).
Also remove the one instance of an unused variable.
BUG=69421
TEST=buildbots all compile and all tests pass
Review URL: http://codereview.chromium.org/6300001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views')
| -rw-r--r-- | views/view_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/views/view_unittest.cc b/views/view_unittest.cc index eb0ec47..cf6fd88 100644 --- a/views/view_unittest.cc +++ b/views/view_unittest.cc @@ -776,11 +776,11 @@ TEST_F(ViewTest, HitTestMasks) { gfx::Point v2_origin = v2_bounds.origin(); // Test HitTest - EXPECT_EQ(true, v1->HitTest(ConvertPointToView(v1, v1_centerpoint))); - EXPECT_EQ(true, v2->HitTest(ConvertPointToView(v2, v2_centerpoint))); + EXPECT_TRUE(v1->HitTest(ConvertPointToView(v1, v1_centerpoint))); + EXPECT_TRUE(v2->HitTest(ConvertPointToView(v2, v2_centerpoint))); - EXPECT_EQ(true, v1->HitTest(ConvertPointToView(v1, v1_origin))); - EXPECT_EQ(false, v2->HitTest(ConvertPointToView(v2, v2_origin))); + EXPECT_TRUE(v1->HitTest(ConvertPointToView(v1, v1_origin))); + EXPECT_FALSE(v2->HitTest(ConvertPointToView(v2, v2_origin))); // Test GetViewForPoint EXPECT_EQ(v1, root_view->GetViewForPoint(v1_centerpoint)); |