diff options
author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-25 22:35:13 +0000 |
---|---|---|
committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-25 22:35:13 +0000 |
commit | 8d8c773c297d22dbf01e2bbb69b7335f52208845 (patch) | |
tree | d45e8affaa57b2dd2516e14c03c3a5f9238247f0 /views | |
parent | 93543752960447decfc8f0ca38ef9f44f7209cfd (diff) | |
download | chromium_src-8d8c773c297d22dbf01e2bbb69b7335f52208845.zip chromium_src-8d8c773c297d22dbf01e2bbb69b7335f52208845.tar.gz chromium_src-8d8c773c297d22dbf01e2bbb69b7335f52208845.tar.bz2 |
Re-land: Create a new views_aura_desktop.
Get views::Widget rendering working against an aura::Window NativeWidget.
http://crbug.com/93944
TEST=none
Original review URL: http://codereview.chromium.org/7741027
Review URL: http://codereview.chromium.org/7747032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98331 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views')
-rw-r--r-- | views/DEPS | 1 | ||||
-rw-r--r-- | views/aura_desktop/aura_desktop_main.cc | 106 | ||||
-rw-r--r-- | views/controls/menu/menu_controller.cc | 10 | ||||
-rw-r--r-- | views/focus/accelerator_handler_aura.cc | 20 | ||||
-rw-r--r-- | views/view_aura.cc | 21 | ||||
-rw-r--r-- | views/views.gyp | 59 | ||||
-rw-r--r-- | views/widget/native_widget_aura.cc | 178 | ||||
-rw-r--r-- | views/widget/native_widget_aura.h | 11 |
8 files changed, 388 insertions, 18 deletions
@@ -1,4 +1,5 @@ include_rules = [ + "+aura", "+grit/ui_resources.h", "+grit/ui_resources_standard.h", "+grit/ui_resources_large.h", diff --git a/views/aura_desktop/aura_desktop_main.cc b/views/aura_desktop/aura_desktop_main.cc new file mode 100644 index 0000000..ce6f3a7 --- /dev/null +++ b/views/aura_desktop/aura_desktop_main.cc @@ -0,0 +1,106 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "aura/desktop.h" +#include "aura/desktop_host.h" +#include "aura/window.h" +#include "aura/window_delegate.h" +#include "base/at_exit.h" +#include "base/command_line.h" +#include "base/i18n/icu_util.h" +#include "base/memory/scoped_ptr.h" +#include "base/message_loop.h" +#include "third_party/skia/include/core/SkXfermode.h" +#include "ui/base/resource/resource_bundle.h" +#include "ui/base/ui_base_paths.h" +#include "ui/gfx/canvas.h" +#include "ui/gfx/canvas_skia.h" +#include "ui/gfx/rect.h" +#include "views/widget/widget.h" + +namespace { + +// Trivial WindowDelegate implementation that draws a colored background. +class DemoWindowDelegate : public aura::WindowDelegate { + public: + explicit DemoWindowDelegate(SkColor color) : color_(color) {} + + virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE { + canvas->AsCanvasSkia()->drawColor(color_, SkXfermode::kSrc_Mode); + } + + private: + SkColor color_; + + DISALLOW_COPY_AND_ASSIGN(DemoWindowDelegate); +}; + +class TestView : public views::View { + public: + TestView() {} + virtual ~TestView() {} + + private: + // Overridden from views::View: + virtual void OnPaint(gfx::Canvas* canvas) { + canvas->FillRectInt(SK_ColorYELLOW, 0, 0, width(), height()); + } + + DISALLOW_COPY_AND_ASSIGN(TestView); +}; + +} // namespace + +int main(int argc, char** argv) { + CommandLine::Init(argc, argv); + + // The exit manager is in charge of calling the dtors of singleton objects. + base::AtExitManager exit_manager; + + ui::RegisterPathProvider(); + icu_util::Initialize(); + ResourceBundle::InitSharedInstance("en-US"); + +#if defined(USE_X11) + base::MessagePumpX::DisableGtkMessagePump(); +#endif + + aura::Desktop::GetInstance(); + + // Create a hierarchy of test windows. + DemoWindowDelegate window_delegate1(SK_ColorBLUE); + aura::Window window1(&window_delegate1); + window1.set_id(1); + window1.Init(); + window1.SetBounds(gfx::Rect(100, 100, 400, 400), 0); + window1.SetVisibility(aura::Window::VISIBILITY_SHOWN); + window1.SetParent(NULL); + + DemoWindowDelegate window_delegate2(SK_ColorRED); + aura::Window window2(&window_delegate2); + window2.set_id(2); + window2.Init(); + window2.SetBounds(gfx::Rect(200, 200, 350, 350), 0); + window2.SetVisibility(aura::Window::VISIBILITY_SHOWN); + window2.SetParent(NULL); + + DemoWindowDelegate window_delegate3(SK_ColorGREEN); + aura::Window window3(&window_delegate3); + window3.set_id(3); + window3.Init(); + window3.SetBounds(gfx::Rect(10, 10, 50, 50), 0); + window3.SetVisibility(aura::Window::VISIBILITY_SHOWN); + window3.SetParent(&window2); + + views::Widget widget; + views::Widget::InitParams params(views::Widget::InitParams::TYPE_CONTROL); + params.bounds = gfx::Rect(75, 75, 80, 80); + params.parent = &window2; + widget.Init(params); + widget.SetContentsView(new TestView); + + aura::Desktop::GetInstance()->Run(); + return 0; +} + diff --git a/views/controls/menu/menu_controller.cc b/views/controls/menu/menu_controller.cc index a87b9ea..7cfbb3a 100644 --- a/views/controls/menu/menu_controller.cc +++ b/views/controls/menu/menu_controller.cc @@ -1748,7 +1748,12 @@ bool MenuController::SelectByChar(char16 character) { return false; } -#if defined(OS_WIN) && !defined(USE_AURA) +#if defined(OS_WIN) +#if defined(USE_AURA) +void MenuController::RepostEvent(SubmenuView* source, + const MouseEvent& event) { +} +#else void MenuController::RepostEvent(SubmenuView* source, const MouseEvent& event) { if (!state_.item) { @@ -1815,7 +1820,8 @@ void MenuController::RepostEvent(SubmenuView* source, } } } -#endif +#endif // !defined(USE_AURA) +#endif // defined(OS_WIN) void MenuController::SetDropMenuItem( MenuItemView* new_target, diff --git a/views/focus/accelerator_handler_aura.cc b/views/focus/accelerator_handler_aura.cc new file mode 100644 index 0000000..8f2f31a --- /dev/null +++ b/views/focus/accelerator_handler_aura.cc @@ -0,0 +1,20 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "views/focus/accelerator_handler.h" + +namespace views { + +AcceleratorHandler::AcceleratorHandler() { +} + +bool AcceleratorHandler::Dispatch(const MSG& msg) { +#if defined(OS_WIN) + TranslateMessage(&msg); + DispatchMessage(&msg); +#endif + return true; +} + +} // namespace views diff --git a/views/view_aura.cc b/views/view_aura.cc new file mode 100644 index 0000000..f01e9b9 --- /dev/null +++ b/views/view_aura.cc @@ -0,0 +1,21 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "views/view.h" + +namespace views { + +gfx::NativeViewAccessible View::GetNativeViewAccessible() { + return NULL; +} + +int View::GetHorizontalDragThreshold() { + return 0; +} + +int View::GetVerticalDragThreshold() { + return 0; +} + +} // namespace views diff --git a/views/views.gyp b/views/views.gyp index 8415705..98bd2d4 100644 --- a/views/views.gyp +++ b/views/views.gyp @@ -242,6 +242,7 @@ 'events/event_utils_win.h', 'events/event_x.cc', 'focus/accelerator_handler.h', + 'focus/accelerator_handler_aura.cc', 'focus/accelerator_handler_gtk.cc', 'focus/accelerator_handler_touch.cc', 'focus/accelerator_handler_win.cc', @@ -310,6 +311,7 @@ 'touchui/touch_selection_controller_impl.h', 'view.cc', 'view.h', + 'view_aura.cc', 'view_constants.cc', 'view_constants.h', 'view_gtk.cc', @@ -396,6 +398,16 @@ 'widget/child_window_message_processor.cc', 'widget/child_window_message_processor.h', ], + 'conditions': [ + ['OS=="win"', { + 'sources/': [ + ['include', 'controls/menu/menu_config_win.cc'], + ['include', 'controls/menu/menu_item_view_win.cc'], + ['include', 'controls/menu/menu_separator_win.cc'], + ['include', 'drag_utils_win.cc'], + ], + }], + ], }], ['toolkit_uses_gtk == 1', { 'dependencies': [ @@ -766,7 +778,50 @@ }], ], }, - - + ], + 'conditions': [ + ['use_aura==1', { + 'targets': [ + { + 'target_name': 'views_aura_desktop', + 'type': 'executable', + 'dependencies': [ + '../base/base.gyp:base', + '../base/base.gyp:base_i18n', + '../skia/skia.gyp:skia', + '../third_party/icu/icu.gyp:icui18n', + '../third_party/icu/icu.gyp:icuuc', + '../ui/ui.gyp:gfx_resources', + '../ui/ui.gyp:ui', + '../ui/ui.gyp:ui_resources', + '../ui/ui.gyp:ui_resources_standard', + 'views', + 'views_desktop_lib', + ], + 'include_dirs': [ + '..', + ], + 'sources': [ + 'aura_desktop/aura_desktop_main.cc', + '<(SHARED_INTERMEDIATE_DIR)/ui/gfx/gfx_resources.rc', + '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources/ui_resources.rc', + '<(SHARED_INTERMEDIATE_DIR)/ui/ui_resources_standard/ui_resources_standard.rc', + ], + 'conditions': [ + ['OS=="win"', { + 'link_settings': { + 'libraries': [ + '-limm32.lib', + '-loleacc.lib', + ] + }, + 'include_dirs': [ + '<(DEPTH)/third_party/wtl/include', + ], + }], + ], + }, + ], + }], ], } diff --git a/views/widget/native_widget_aura.cc b/views/widget/native_widget_aura.cc index 38d6d42..8116a0d 100644 --- a/views/widget/native_widget_aura.cc +++ b/views/widget/native_widget_aura.cc @@ -4,12 +4,20 @@ #include "views/widget/native_widget_aura.h" +#include "aura/window.h" +#include "ui/gfx/canvas.h" +#include "ui/gfx/compositor/layer.h" +#include "views/widget/native_widget_delegate.h" + namespace views { //////////////////////////////////////////////////////////////////////////////// // NativeWidgetAura, public: -NativeWidgetAura::NativeWidgetAura(internal::NativeWidgetDelegate* delegate) { +NativeWidgetAura::NativeWidgetAura(internal::NativeWidgetDelegate* delegate) + : delegate_(delegate), + ALLOW_THIS_IN_INITIALIZER_LIST(window_(new aura::Window(this))) { + window_->set_id(1200); } NativeWidgetAura::~NativeWidgetAura() { @@ -19,36 +27,46 @@ NativeWidgetAura::~NativeWidgetAura() { // NativeWidgetAura, internal::NativeWidgetPrivate implementation: void NativeWidgetAura::InitNativeWidget(const Widget::InitParams& params) { + window_->Init(); + window_->SetBounds(params.bounds, 0); + window_->SetParent(params.parent); + // TODO(beng): do this some other way. + delegate_->OnNativeWidgetSizeChanged(params.bounds.size()); + window_->SetVisibility(aura::Window::VISIBILITY_SHOWN); } NonClientFrameView* NativeWidgetAura::CreateNonClientFrameView() { + NOTIMPLEMENTED(); return NULL; } void NativeWidgetAura::UpdateFrameAfterFrameChange() { + NOTIMPLEMENTED(); } bool NativeWidgetAura::ShouldUseNativeFrame() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::FrameTypeChanged() { + NOTIMPLEMENTED(); } Widget* NativeWidgetAura::GetWidget() { - return NULL; + return delegate_->AsWidget(); } const Widget* NativeWidgetAura::GetWidget() const { - return NULL; + return delegate_->AsWidget(); } gfx::NativeView NativeWidgetAura::GetNativeView() const { - return NULL; + return window_; } gfx::NativeWindow NativeWidgetAura::GetNativeWindow() const { - return NULL; + return window_; } Widget* NativeWidgetAura::GetTopLevelWidget() { @@ -57,106 +75,133 @@ Widget* NativeWidgetAura::GetTopLevelWidget() { } const ui::Compositor* NativeWidgetAura::GetCompositor() const { - return NULL; + return window_->layer()->compositor(); } ui::Compositor* NativeWidgetAura::GetCompositor() { - return NULL; + return window_->layer()->compositor(); } void NativeWidgetAura::MarkLayerDirty() { + NOTIMPLEMENTED(); } void NativeWidgetAura::CalculateOffsetToAncestorWithLayer(gfx::Point* offset, View** ancestor) { + NOTIMPLEMENTED(); } void NativeWidgetAura::ViewRemoved(View* view) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetNativeWindowProperty(const char* name, void* value) { + NOTIMPLEMENTED(); } void* NativeWidgetAura::GetNativeWindowProperty(const char* name) const { + NOTIMPLEMENTED(); return NULL; } TooltipManager* NativeWidgetAura::GetTooltipManager() const { + NOTIMPLEMENTED(); return NULL; } bool NativeWidgetAura::IsScreenReaderActive() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::SendNativeAccessibilityEvent( View* view, ui::AccessibilityTypes::Event event_type) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetMouseCapture() { + NOTIMPLEMENTED(); } void NativeWidgetAura::ReleaseMouseCapture() { + NOTIMPLEMENTED(); } bool NativeWidgetAura::HasMouseCapture() const { + NOTIMPLEMENTED(); return false; } InputMethod* NativeWidgetAura::CreateInputMethod() { + NOTIMPLEMENTED(); return NULL; } void NativeWidgetAura::CenterWindow(const gfx::Size& size) { + NOTIMPLEMENTED(); } void NativeWidgetAura::GetWindowBoundsAndMaximizedState(gfx::Rect* bounds, bool* maximized) const { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetWindowTitle(const std::wstring& title) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetWindowIcons(const SkBitmap& window_icon, const SkBitmap& app_icon) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetAccessibleName(const std::wstring& name) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetAccessibleRole(ui::AccessibilityTypes::Role role) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetAccessibleState(ui::AccessibilityTypes::State state) { + NOTIMPLEMENTED(); } void NativeWidgetAura::BecomeModal() { + NOTIMPLEMENTED(); } gfx::Rect NativeWidgetAura::GetWindowScreenBounds() const { - return gfx::Rect(); + // TODO(beng): ensure screen bounds + return window_->bounds(); } gfx::Rect NativeWidgetAura::GetClientAreaScreenBounds() const { - return gfx::Rect(); + // TODO(beng): + return window_->bounds(); } gfx::Rect NativeWidgetAura::GetRestoredBounds() const { - return gfx::Rect(); + // TODO(beng): + return window_->bounds(); } void NativeWidgetAura::SetBounds(const gfx::Rect& bounds) { + window_->SetBounds(bounds, 0); } void NativeWidgetAura::SetSize(const gfx::Size& size) { + window_->SetBounds(gfx::Rect(window_->bounds().origin(), size), 0); } void NativeWidgetAura::SetBoundsConstrained(const gfx::Rect& bounds, - Widget* other_widget) { + Widget* other_widget) { + NOTIMPLEMENTED(); } void NativeWidgetAura::MoveAbove(gfx::NativeView native_view) { + NOTIMPLEMENTED(); } void NativeWidgetAura::MoveToTop() { @@ -164,105 +209,212 @@ void NativeWidgetAura::MoveToTop() { } void NativeWidgetAura::SetShape(gfx::NativeRegion region) { + NOTIMPLEMENTED(); } void NativeWidgetAura::Close() { + NOTIMPLEMENTED(); } void NativeWidgetAura::CloseNow() { + NOTIMPLEMENTED(); } void NativeWidgetAura::EnableClose(bool enable) { + NOTIMPLEMENTED(); } void NativeWidgetAura::Show() { + window_->SetVisibility(aura::Window::VISIBILITY_SHOWN); } void NativeWidgetAura::Hide() { + window_->SetVisibility(aura::Window::VISIBILITY_HIDDEN); } void NativeWidgetAura::ShowMaximizedWithBounds( const gfx::Rect& restored_bounds) { + NOTIMPLEMENTED(); } void NativeWidgetAura::ShowWithState(ShowState state) { + NOTIMPLEMENTED(); } bool NativeWidgetAura::IsVisible() const { - return false; + return window_->visibility() != aura::Window::VISIBILITY_HIDDEN; } void NativeWidgetAura::Activate() { + NOTIMPLEMENTED(); } void NativeWidgetAura::Deactivate() { + NOTIMPLEMENTED(); } bool NativeWidgetAura::IsActive() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::SetAlwaysOnTop(bool on_top) { + NOTIMPLEMENTED(); } void NativeWidgetAura::Maximize() { + NOTIMPLEMENTED(); } void NativeWidgetAura::Minimize() { + NOTIMPLEMENTED(); } bool NativeWidgetAura::IsMaximized() const { + NOTIMPLEMENTED(); return false; } bool NativeWidgetAura::IsMinimized() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::Restore() { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetFullscreen(bool fullscreen) { + NOTIMPLEMENTED(); } bool NativeWidgetAura::IsFullscreen() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::SetOpacity(unsigned char opacity) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetUseDragFrame(bool use_drag_frame) { + NOTIMPLEMENTED(); } bool NativeWidgetAura::IsAccessibleWidget() const { + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::RunShellDrag(View* view, const ui::OSExchangeData& data, int operation) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SchedulePaintInRect(const gfx::Rect& rect) { + NOTIMPLEMENTED(); } void NativeWidgetAura::SetCursor(gfx::NativeCursor cursor) { + NOTIMPLEMENTED(); } void NativeWidgetAura::ClearNativeFocus() { + NOTIMPLEMENTED(); } void NativeWidgetAura::FocusNativeView(gfx::NativeView native_view) { + NOTIMPLEMENTED(); } bool NativeWidgetAura::ConvertPointFromAncestor(const Widget* ancestor, gfx::Point* point) const { - NOTREACHED(); + NOTIMPLEMENTED(); return false; } void NativeWidgetAura::DispatchKeyEventPostIME(const KeyEvent& key) { + NOTIMPLEMENTED(); +} + +//////////////////////////////////////////////////////////////////////////////// +// NativeWidgetAura, aura::WindowDelegate implementation: + +void NativeWidgetAura::OnPaint(gfx::Canvas* canvas) { + delegate_->OnNativeWidgetPaint(canvas); +} + +//////////////////////////////////////////////////////////////////////////////// +// Widget, public: + +// static +void Widget::NotifyLocaleChanged() { + NOTIMPLEMENTED(); +} + +// static +void Widget::CloseAllSecondaryWidgets() { + NOTIMPLEMENTED(); +} + +bool Widget::ConvertRect(const Widget* source, + const Widget* target, + gfx::Rect* rect) { + return false; +} + + + +namespace internal { + +//////////////////////////////////////////////////////////////////////////////// +// internal::NativeWidgetPrivate, public: + +// static +NativeWidgetPrivate* NativeWidgetPrivate::CreateNativeWidget( + internal::NativeWidgetDelegate* delegate) { + return new NativeWidgetAura(delegate); +} + +// static +NativeWidgetPrivate* NativeWidgetPrivate::GetNativeWidgetForNativeView( + gfx::NativeView native_view) { + NOTIMPLEMENTED(); + return NULL; +} + +// static +NativeWidgetPrivate* NativeWidgetPrivate::GetNativeWidgetForNativeWindow( + gfx::NativeWindow native_window) { + NOTIMPLEMENTED(); + return NULL; +} + +// static +NativeWidgetPrivate* NativeWidgetPrivate::GetTopLevelNativeWidget( + gfx::NativeView native_view) { + NOTIMPLEMENTED(); + return NULL; +} + +// static +void NativeWidgetPrivate::GetAllChildWidgets(gfx::NativeView native_view, + Widget::Widgets* children) { + NOTIMPLEMENTED(); +} + +// static +void NativeWidgetPrivate::ReparentNativeView(gfx::NativeView native_view, + gfx::NativeView new_parent) { + NOTIMPLEMENTED(); +} + +// static +bool NativeWidgetPrivate::IsMouseButtonDown() { + NOTIMPLEMENTED(); + return false; } +} // namespace internal } // namespace views diff --git a/views/widget/native_widget_aura.h b/views/widget/native_widget_aura.h index ab3ff9c..ad9af1f 100644 --- a/views/widget/native_widget_aura.h +++ b/views/widget/native_widget_aura.h @@ -6,11 +6,13 @@ #define VIEWS_WIDGET_NATIVE_WIDGET_AURA_H_ #pragma once +#include "aura/window_delegate.h" #include "views/widget/native_widget_private.h" namespace views { -class NativeWidgetAura : public internal::NativeWidgetPrivate { +class NativeWidgetAura : public internal::NativeWidgetPrivate, + public aura::WindowDelegate { public: explicit NativeWidgetAura(internal::NativeWidgetDelegate* delegate); virtual ~NativeWidgetAura(); @@ -97,7 +99,14 @@ class NativeWidgetAura : public internal::NativeWidgetPrivate { const Widget* ancestor, gfx::Point* point) const OVERRIDE; virtual void DispatchKeyEventPostIME(const KeyEvent& key) OVERRIDE; + // Overridden from aura::WindowDelegate: + virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE; + private: + internal::NativeWidgetDelegate* delegate_; + + aura::Window* window_; + DISALLOW_COPY_AND_ASSIGN(NativeWidgetAura); }; |